Skip to content

[analyzer] Fix wrong builtin_*_overflow return type #111253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2024

fix formatting

dcfd42f
Select commit
Loading
Failed to load commit list.
Merged

[analyzer] Fix wrong builtin_*_overflow return type #111253

fix formatting
dcfd42f
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Graphite App / Graphite / ai_reviewer check succeeded Oct 5, 2024 in 0s

Graphite AI review summary

This change modifies the BuiltinFunctionChecker to use the correct boolean type when handling overflow builtins. It also adds a test case to ensure that _builtin*_overflow functions return _Bool instead of int.

Left no comments. Looks good to me!

Details

View more details on Graphite App