Skip to content

[Legacy ThinLTO] NFC: Move helper class to an "Impl" namespace #112846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[Legacy ThinLTO] NFC: Move helper class to an "Impl" namespace #112846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,15 @@ namespace llvm {
class StringRef;
class TargetMachine;

/// ThinLTOCodeGeneratorImpl - Namespace used for ThinLTOCodeGenerator
/// implementation details. It should be considered private to the
/// implementation.
namespace ThinLTOCodeGeneratorImpl {
struct TargetMachineBuilder;
}

/// Helper to gather options relevant to the target machine creation
struct TargetMachineBuilder {
struct ThinLTOCodeGeneratorImpl::TargetMachineBuilder {
Triple TheTriple;
std::string MCpu;
std::string MAttr;
Expand Down Expand Up @@ -301,7 +308,7 @@ class ThinLTOCodeGenerator {

private:
/// Helper factory to build a TargetMachine
TargetMachineBuilder TMBuilder;
ThinLTOCodeGeneratorImpl::TargetMachineBuilder TMBuilder;

/// Vector holding the in-memory buffer containing the produced binaries, when
/// SavedObjectsDirectoryPath isn't set.
Expand Down
1 change: 1 addition & 0 deletions llvm/lib/LTO/ThinLTOCodeGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
#endif

using namespace llvm;
using namespace ThinLTOCodeGeneratorImpl;

#define DEBUG_TYPE "thinlto"

Expand Down
Loading