[llvm][docs] Clean up the "Landing Your Change" section of the GitHub docs #112869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DavidSpickett
commented
Oct 18, 2024
•
DavidSpickett
commented
- Note up front that the author may not have permissions to use the merge button and should ask a reviewer to do those steps.
- Make it clear that a single commit PR can be landed with a single button click.
- There are in fact 3 ways to land a multi-commit PR.
- Order the ways in increasing amount of overhead for the PR author.
- Put them in bullet point sections so they are visually separate.
… docs * Note up front that the author may not have permissions to use the merge button and should ask a reviewer to do those steps. * Make it clear that a single commit PR can be landed with a single button click. * There are in fact 3 ways to land a multi-commit PR. * Order the ways in increasing amount of overhead for the PR author. * Put them in bullet point sections so they are visualy separate.
|
@JL2210 This may address some of your feedback on the doc. I will look at the doc as a whole in another PR. |
JL2210
reviewed
Oct 18, 2024
|
This looks fine to me. Much more clear than it was. |
nickdesaulniers
approved these changes
Oct 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.