-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[HLSL] Add Increment
/DecrementCounter
methods to structured buffers
#114148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8c76f28
[HLSL] Add Increment/DecrementCounter methods to structured buffers
hekota a94c901
Code review feedback - add test & asserts, add Sema to main decl buil…
hekota eb26a6f
Merge branch 'main' of https://github.com/llvm/llvm-project into sb4-…
hekota 0f4c61f
Code review feedback - assert of completed definition or no method body
hekota f180391
clang-format
hekota 942af76
Code review feedback - remove unused method, add comment
hekota 8119cd0
Merge branch 'main' of https://github.com/llvm/llvm-project into sb4-…
hekota ed6d0f9
Add Increment/DecrementCounter to RasterizerOrderedStructuredBuffer; …
hekota 7fe5623
Remove accidentally added file; update builtin to not be Const
hekota d04755b
Add comments, make getResourceHandleExpr public, add const int helper…
hekota bc336cb
code review feedback
hekota 730b80e
Merge branch 'main' of https://github.com/llvm/llvm-project into sb4-…
hekota 170e390
fix merge
hekota ba8be73
Merge branch 'main' of https://github.com/llvm/llvm-project into sb4-…
hekota d8f3d9c
Update intrinsics name and arguments to match DXIL and SPIRV.
hekota 6f2496c
Merge branch 'main' of https://github.com/llvm/llvm-project into sb4-…
hekota 6271433
Add bitcast from builtin i32 param to intrinsic's i8
hekota e3ad5e6
Merge branch 'main' of https://github.com/llvm/llvm-project into sb4-…
hekota 4b70b99
code review feedback, fix merge, remove unused addConceptSpecializati…
hekota 00ad032
Rename S to SemaRef & clang-format
hekota b2ec3ad
Merge branch 'main' of https://github.com/llvm/llvm-project into sb4-…
hekota File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7287,6 +7287,8 @@ def err_typecheck_illegal_increment_decrement : Error< | |
"cannot %select{decrement|increment}1 value of type %0">; | ||
def err_typecheck_expect_int : Error< | ||
"used type %0 where integer is required">; | ||
def err_typecheck_expect_hlsl_resource : Error< | ||
"used type %0 where __hlsl_resource_t is required">; | ||
def err_typecheck_arithmetic_incomplete_or_sizeless_type : Error< | ||
"arithmetic on a pointer to %select{an incomplete|sizeless}0 type %1">; | ||
def err_typecheck_pointer_arith_function_type : Error< | ||
|
@@ -12528,6 +12530,10 @@ def warn_attr_min_eq_max: Warning< | |
|
||
def err_hlsl_attribute_number_arguments_insufficient_shader_model: Error< | ||
"attribute %0 with %1 arguments requires shader model %2 or greater">; | ||
def err_hlsl_expect_arg_const_int_one_or_neg_one: Error< | ||
"argument %0 must be constant integer 1 or -1">; | ||
def err_invalid_hlsl_resource_type: Error< | ||
"invalid __hlsl_resource_t type attributes">; | ||
Comment on lines
+12533
to
+12536
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These messages feel like they're generic enough that we could reuse some existing diagnostic, but I don't really see anything that works. These are probably fine, but we should make sure to pay attention to adding too many new diagnostics if/when we don't need to. |
||
|
||
// Layout randomization diagnostics. | ||
def err_non_designated_init_used : Error< | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.