[libc] Remove _Exit proxy func header and use LIBC_NAMESPACE::_Exit in tests #114904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@llvm/pr-subscribers-libc Author: Job Henandez Lara (Jobhdez) ChangesThis improves/fixes this pr #114718. In this pr we added an _Exit declaration to Full diff: https://github.com/llvm/llvm-project/pull/114904.diff 1 Files Affected:
diff --git a/libc/hdr/func/_Exit.h b/libc/hdr/func/_Exit.h
index e024a651a50bcf..b8160e9af3e4e3 100644
--- a/libc/hdr/func/_Exit.h
+++ b/libc/hdr/func/_Exit.h
@@ -10,8 +10,7 @@
#define LLVM_LIBC_HDR_FUNC_EXIT_H
#ifdef LIBC_FULL_BUILD
-// We will use the `_Exit` declaration from our generated stdlib.h
-#include <stdlib.h>
+extern "C" [[noreturn]] void _Exit(int) noexcept;
#else // Overlay mode
|
nickdesaulniers
approved these changes
Nov 5, 2024
michaelrj-google
requested changes
Nov 5, 2024
Yeah this makes sense. I will update the PR to remove the |
|
Yes that sounds like the correct thing to do. Thank you! |
No problem! |
ok I will. do you want me to merge after I change the title? or do you want to merge yourself? |
michaelrj-google
approved these changes
Nov 7, 2024
ok ill wait until tomorrow morning. thanks. can you please suggest a new title for the pr? thanks |
You can change it to |
ghost
changed the title
ok sounds good. I'm going to merge now! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/9876 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/71/builds/10064 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/131/builds/9925 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/179/builds/9800 Here is the relevant piece of the build log for the reference |
| @@ -6,7 +6,6 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #include "hdr/func/_Exit.h" | |||
There was a problem hiding this comment.
looks like you need to include _Exit here explicitly (#include "src/stdlib/_Exit.h). Applies to both tests.
There was a problem hiding this comment.
im working on it now. its building in full build mode
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/196/builds/680 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/183/builds/5946 Here is the relevant piece of the build log for the reference |
ghost
mentioned this pull request
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…n tests (llvm#114904) This improves/fixes this pr llvm#114718. In this PR we removed the _Exit proxy func because it was not needed. Instead we used `LIBC_NAMESPACE::_Exit`
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…` and `atexit_test.cpp` (llvm#115351) Hello, I merged this llvm#114904 a few mins ago and the tests failed because i did not add the header `src/stdlib/_Exit.h` in `at_quick_exit_test.cpp` and `atexit_test.cpp`. I ran both builds/tests and everything was good. thanks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves/fixes this pr #114718. In this PR we removed the _Exit proxy func because it was not needed. Instead we used
LIBC_NAMESPACE::_Exit