Skip to content

[clang] wasm cpu name is supposed to be lime1, not lime #119262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

programmerjake
Copy link
Contributor

Originally added in #112035
cc @sunfishcode

@llvmbot llvmbot added clang Clang issues not falling into any other category backend:WebAssembly clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Dec 9, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 9, 2024

@llvm/pr-subscribers-backend-webassembly

Author: Jacob Lifshay (programmerjake)

Changes

Originally added in #112035
cc @sunfishcode


Full diff: https://github.com/llvm/llvm-project/pull/119262.diff

1 Files Affected:

  • (modified) clang/lib/Basic/Targets/WebAssembly.cpp (+1-1)
diff --git a/clang/lib/Basic/Targets/WebAssembly.cpp b/clang/lib/Basic/Targets/WebAssembly.cpp
index a837c3df99217e..14f1ac20747f5a 100644
--- a/clang/lib/Basic/Targets/WebAssembly.cpp
+++ b/clang/lib/Basic/Targets/WebAssembly.cpp
@@ -35,7 +35,7 @@ static constexpr auto BuiltinStorage = Builtin::Storage<NumBuiltins>::Make(
       });
 
 static constexpr llvm::StringLiteral ValidCPUNames[] = {
-    {"mvp"}, {"bleeding-edge"}, {"generic"}, {"lime"}};
+    {"mvp"}, {"bleeding-edge"}, {"generic"}, {"lime1"}};
 
 StringRef WebAssemblyTargetInfo::getABI() const { return ABI; }
 

@llvmbot
Copy link
Member

llvmbot commented Dec 9, 2024

@llvm/pr-subscribers-clang

Author: Jacob Lifshay (programmerjake)

Changes

Originally added in #112035
cc @sunfishcode


Full diff: https://github.com/llvm/llvm-project/pull/119262.diff

1 Files Affected:

  • (modified) clang/lib/Basic/Targets/WebAssembly.cpp (+1-1)
diff --git a/clang/lib/Basic/Targets/WebAssembly.cpp b/clang/lib/Basic/Targets/WebAssembly.cpp
index a837c3df99217e..14f1ac20747f5a 100644
--- a/clang/lib/Basic/Targets/WebAssembly.cpp
+++ b/clang/lib/Basic/Targets/WebAssembly.cpp
@@ -35,7 +35,7 @@ static constexpr auto BuiltinStorage = Builtin::Storage<NumBuiltins>::Make(
       });
 
 static constexpr llvm::StringLiteral ValidCPUNames[] = {
-    {"mvp"}, {"bleeding-edge"}, {"generic"}, {"lime"}};
+    {"mvp"}, {"bleeding-edge"}, {"generic"}, {"lime1"}};
 
 StringRef WebAssemblyTargetInfo::getABI() const { return ABI; }
 

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunfishcode sunfishcode merged commit 0ee5924 into llvm:main Dec 10, 2024
12 checks passed
@programmerjake programmerjake deleted the patch-2 branch December 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:WebAssembly clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants