-
Notifications
You must be signed in to change notification settings - Fork 14.1k
[lldb][AIX] XCOFF clang-format and other minor changes #119892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please rebase this so it is just one commit to merge into (if I implied it should include the new comments, my apologies) |
Formatting existing comments is fine to include here. |
Not a problem, I probably just got a bit excited 😛 |
Let me give it a try manually |
@DhruvSrivastavaX I realised I can do the squash when I merge it. I was confused by seeing so many commits here but the final changes are correct anyway. |
Yes, I was trying to resolve a couple of conflicts in a better way, since the branch had diverged quite some time back. |
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
Added XCOFF Object File Header Parsing for AIX.
This PR is an incremental PR to the base:
#111814
Details about XCOFF file format on AIX: XCOFF
Added some clang-format and other minor changes, Ref: #116338 (comment)
Review Request: @DavidSpickett