Skip to content

[APINotes] Avoid assertion failure with expensive checks #120487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clang/lib/APINotes/APINotesReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2045,7 +2045,12 @@ APINotesReader::VersionedInfo<T>::VersionedInfo(
Results.begin(), Results.end(),
[](const std::pair<llvm::VersionTuple, T> &left,
const std::pair<llvm::VersionTuple, T> &right) -> bool {
assert(left.first != right.first && "two entries for the same version");
// The comparison function should be reflective, and with expensive
// checks we can get callbacks basically checking that lambda(a,a) is
// false. We could still check that we do not find equal elements when
// left!=right.
assert((&left == &right || left.first != right.first) &&
"two entries for the same version");
return left.first < right.first;
}));

Expand Down
Loading