[NFC][analyzer][docs] Remove some orphaned images #122249
Conversation
Remove some images that were previously used on the old homepage of Clang static analyzer (`clang-analyzer.llvm.org`) but became unused since then. Among the four removed images, `scan_build_cmd.png` was copied to a different location within the repository (and the RST-based docs use it from that location); while the other three are not referenced at all (`git grep` produces no results).
|
@llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) ChangesRemove some images that were previously used on the old homepage of Clang static analyzer ( Among the four removed images, Full diff: https://github.com/llvm/llvm-project/pull/122249.diff 4 Files Affected:
diff --git a/clang/www/analyzer/images/example_custom_assert.png b/clang/www/analyzer/images/example_custom_assert.png
deleted file mode 100644
index a56bb8962453fe..00000000000000
Binary files a/clang/www/analyzer/images/example_custom_assert.png and /dev/null differ
diff --git a/clang/www/analyzer/images/example_null_pointer.png b/clang/www/analyzer/images/example_null_pointer.png
deleted file mode 100644
index defc3948e9c700..00000000000000
Binary files a/clang/www/analyzer/images/example_null_pointer.png and /dev/null differ
diff --git a/clang/www/analyzer/images/example_use_assert.png b/clang/www/analyzer/images/example_use_assert.png
deleted file mode 100644
index 9e46d7614d625c..00000000000000
Binary files a/clang/www/analyzer/images/example_use_assert.png and /dev/null differ
diff --git a/clang/www/analyzer/images/scan_build_cmd.png b/clang/www/analyzer/images/scan_build_cmd.png
deleted file mode 100644
index 464fd4e129a208..00000000000000
Binary files a/clang/www/analyzer/images/scan_build_cmd.png and /dev/null differ
|
|
Its usually good practice to refer to the last commit where the dead resources become dead. Example: You can get a better understanding if the drop was intentional or accidental. |
|
I assumed the correctness of the old commits, but now that I looked into it, it seems that the three |
|
Now that I looked at that PR, it was merged without approval, while having open comments. |
|
I'll create a commit which restores those three images to the RST FAQ. After that, either I or @gamesh411 can create a follow-up commit that addresses any question in the old review that were forgotten. |
|
I created PR #122481 which properly handles these images. |
Remove some images that were previously used on the old homepage of Clang static analyzer (
clang-analyzer.llvm.org) but became unused since then.Among the four removed images,
scan_build_cmd.pngwas copied to a different location within the repository (and the RST-based docs use it from that location); while the other three are not referenced at all (git grepproduces no results).