[clang-tidy] Add a release note about unchecked-optional-access smart pointer caching

[jvoung]

With caching added in #120249, the IgnoreSmartPointerDereference option shouldn't be needed anymore.

Other caching also added earlier: #112605

[llvmbot]

@llvm/pr-subscribers-clang-tidy

@llvm/pr-subscribers-clang-tools-extra

Author: Jan Voung (jvoung)

Changes

With caching added in #120249, the IgnoreSmartPointerDereference option shouldn't be needed anymore.

Other caching also added earlier: #112605

---

Full diff: https://github.com/llvm/llvm-project/pull/122290.diff

1 Files Affected:

• (modified) clang-tools-extra/docs/ReleaseNotes.rst (+4)

diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 94e15639c4a92e..47cc4f6f17fed5 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -232,6 +232,10 @@ Changes in existing checks
   <clang-tidy/checks/bugprone/unchecked-optional-access>` to support
   `bsl::optional` and `bdlb::NullableValue` from
   <https://github.com/bloomberg/bde>_.
+  Fixed false positives from smart pointer accessors repeated in checking
+  ``has_value`` and accessing ``value``, by caching the locations returned
+  by the accessors. The option `IgnoreSmartPointerDereference` should no
+  longer be needed.
 
 - Improved :doc:`bugprone-unhandled-self-assignment
   <clang-tidy/checks/bugprone/unhandled-self-assignment>` check by fixing smart

[HerrCai0907]

does check doc need to be changed also?

[jvoung]

does check doc need to be changed also?

Good question -- I don't see the option IgnoreSmartPointerDereference advertised in the check docs.

Otherwise, we partially updated the check docs about earlier accessor caching. Updated more to mention smart pointer like APIs. Also previously updated internal code comments about IgnoreSmartPointerDereference in the UncheckedOptionalAccessModelOptions struct.

[EugeneZelenko]

Could you please also move readability-identifier-naming entry before readability-implicit-bool-conversion and place :program:run-clang-tidy.py entry after :program:clang-tidy.py?

[jvoung]

program:run-clang-tidy

Sure thing --

Done separately in #122475 (I kept the "Improved" cluster together, vs moving run-clang-tidy to be after the "Removed" block including the table)

For readability-identifier-naming it looks like @HerrCai0907 already reordered that in c01ffab