[SandboxIR][Region] Implement an auxiliary vector in Region #126376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added Region::clearAux(). |
slackito
reviewed
Feb 13, 2025
llvm/include/llvm/SandboxIR/Region.h
Outdated
|
|
||
| /// MDNode that we'll use to mark instructions as being part of the region. | ||
| MDNode *RegionMDN; | ||
| static constexpr const char *MDKind = "sandboxvec"; | ||
| static constexpr const char *RegionStr = "sandboxregion"; | ||
| static constexpr const char *AuxMDKind = "sbaux"; |
There was a problem hiding this comment.
the other names use "sandbox" instead of "sb" as a prefix. Should this be "sandboxaux"? Or even "sandboxregionaux"? (I don't know how long these strings usually are)
There was a problem hiding this comment.
Good point, yeah we should make this consistent. I will change it to "sandboxaux".
| llvm::Constant *IdxC = | ||
| dyn_cast<ConstantAsMetadata>(AuxMDN->getOperand(0))->getValue(); | ||
| auto Idx = cast<llvm::ConstantInt>(IdxC)->getSExtValue(); | ||
| R->setAux(Idx, &Inst); |
There was a problem hiding this comment.
Here we could have a check that we don't have two different values whose metadata claims the same index in the aux vector.
There was a problem hiding this comment.
I added a check in setAux(Idx, I) but this function is only called internally so using the same index shouldn't be possible unless this function is broken.
There was a problem hiding this comment.
You could have incorrect metadata, right? Something like
define void @foo(i8 %v) {
%t0 = add i8 %v, 0, !sandboxvec !0, !sandboxaux !1
%t1 = add i8 %v, 1, !sandboxvec !0, !sandboxaux !1
ret void
}
!0 = distinct !{!"sandboxregion"}
!1 = !{i32 0}
There was a problem hiding this comment.
You are right, I think I should be able to add a test for it too.
slackito
approved these changes
Feb 13, 2025
This patch adds additional functionality to the sandboxir Region. The Region is used as a way of passing a set of Instructions across region passes in a way that can be represented in the IR with metadata. This is a design choice that allows us to test region passes in isolation with lit tests. Up until now the region was only used to tag the instructions generated by the passes. There is a need to represent an ordered set of instructions, which can be used as a way to represent the initial seeds to the first vectorization pass. This patch implements this auxiliary vector that can be used to convey such information.
chapuni
added a commit
that referenced
this pull request
Feb 14, 2025
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
) This patch adds additional functionality to the sandboxir Region. The Region is used as a way of passing a set of Instructions across region passes in a way that can be represented in the IR with metadata. This is a design choice that allows us to test region passes in isolation with lit tests. Up until now the region was only used to tag the instructions generated by the passes. There is a need to represent an ordered set of instructions, which can be used as a way to represent the initial seeds to the first vectorization pass. This patch implements this auxiliary vector that can be used to convey such information.
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
) This patch adds additional functionality to the sandboxir Region. The Region is used as a way of passing a set of Instructions across region passes in a way that can be represented in the IR with metadata. This is a design choice that allows us to test region passes in isolation with lit tests. Up until now the region was only used to tag the instructions generated by the passes. There is a need to represent an ordered set of instructions, which can be used as a way to represent the initial seeds to the first vectorization pass. This patch implements this auxiliary vector that can be used to convey such information.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
RKSimon
reviewed
Feb 27, 2025
| auto &LLVMCtx = Ctx.LLVMCtx; | ||
| for (auto [Idx, I] : enumerate(Aux)) { | ||
| llvm::ConstantInt *IdxC = | ||
| llvm::ConstantInt::get(LLVMCtx, llvm::APInt(32, Idx, false)); |
There was a problem hiding this comment.
https://discourse.llvm.org/t/second-stage-of-build-on-windows-fails-in-sandboxir/84841
@vporpo - could you replace the APInt with the ConstantInt::get(Type *Ty, uint64_t V, bool isSigned) variant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds additional functionality to the sandboxir Region. The Region is used as a way of passing a set of Instructions across region passes in a way that can be represented in the IR with metadata. This is a design choice that allows us to test region passes in isolation with lit tests.
Up until now the region was only used to tag the instructions generated by the passes. There is a need to represent an ordered set of instructions, which can be used as a way to represent the initial seeds to the first vectorization pass. This patch implements this auxiliary vector that can be used to convey such information.