Skip to content

workflows/release-binaries: Fix macos-14 build #127157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

tstellar
Copy link
Collaborator

This was broken when pgo was enabled by
0572580.

This was broken when pgo was enabled by
0572580.
@llvmbot
Copy link
Member

llvmbot commented Feb 14, 2025

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

This was broken when pgo was enabled by
0572580.


Full diff: https://github.com/llvm/llvm-project/pull/127157.diff

1 Files Affected:

  • (modified) .github/workflows/release-binaries.yml (+2-2)
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 204ee6405382f..398734c1a366d 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -133,13 +133,13 @@ jobs:
         # add extra CMake args to disable them.
         # See https://github.com/llvm/llvm-project/issues/99767
         if [ "$RUNNER_OS" = "macOS" ]; then
-          target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_COMPILER_RT_ENABLE_IOS=OFF"
+          target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_BOOTSTRAP_COMPILER_RT_ENABLE_IOS=OFF"
           if [ "$RUNNER_ARCH" = "ARM64" ]; then
             arches=arm64
           else
             arches=x86_64
           fi
-          target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_DARWIN_osx_ARCHS=$arches -DBOOTSTRAP_DARWIN_osx_BUILTIN_ARCHS=$arches"
+          target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_ARCHS=$arches -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_BUILTIN_ARCHS=$arches"
         fi
 
         build_flang="true"

@tstellar tstellar merged commit d595d5a into llvm:main Feb 14, 2025
21 of 25 checks passed
joaosaffran pushed a commit to joaosaffran/llvm-project that referenced this pull request Feb 14, 2025
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
@tstellar tstellar added this to the LLVM 20.X Release milestone Feb 26, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Feb 26, 2025
@tstellar
Copy link
Collaborator Author

/cherry-pick d595d5a

@llvmbot
Copy link
Member

llvmbot commented Feb 26, 2025

/pull-request #128945

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Feb 26, 2025
swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Mar 4, 2025
This was broken when pgo was enabled by
0572580.

(cherry picked from commit d595d5a)
sabitov-kirill added a commit to sabitov-kirill/llvm-project that referenced this pull request Apr 2, 2025
* workflows/release-binaries-all: Add missing secret input (llvm#126921)

Since d194c6b this workflow was missing
the secret input which was causing it to fail.

(cherry picked from commit a684e0e)

* workflows/release-binaries: Fix macos-14 build (llvm#127157)

This was broken when pgo was enabled by
0572580.

(cherry picked from commit d595d5a)

* [clang-format] Fix a bug that changes keyword `or` to an identifier (llvm#128410)

Backports ffc61dc 0968df9 2d585cc

Fixes llvm#105482

* [clangd] Add clangd 20 release notes (llvm#127358)

* Bump version to 20.1.0 (final)

* Add dummy "SystemS" target

* Add barebone SystemS backend initislisation, that can succsesfully perform`CodeGenTargetMachineImpl::initAsmInfo`.

Commit includes simplest form of registers, instructions, subtarget descrption.

Commit includes simple lit test to check how far we can get in performing end-to-end compilation pipeline.

* Add functional backend, that can emit basical asm

* Add different testing scenarious

* Add dag selection to pass config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants