workflows/release-binaries: Fix macos-14 build #127157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken when pgo was enabled by 0572580.
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThis was broken when pgo was enabled by Full diff: https://github.com/llvm/llvm-project/pull/127157.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 204ee6405382f..398734c1a366d 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -133,13 +133,13 @@ jobs:
# add extra CMake args to disable them.
# See https://github.com/llvm/llvm-project/issues/99767
if [ "$RUNNER_OS" = "macOS" ]; then
- target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_COMPILER_RT_ENABLE_IOS=OFF"
+ target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_BOOTSTRAP_COMPILER_RT_ENABLE_IOS=OFF"
if [ "$RUNNER_ARCH" = "ARM64" ]; then
arches=arm64
else
arches=x86_64
fi
- target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_DARWIN_osx_ARCHS=$arches -DBOOTSTRAP_DARWIN_osx_BUILTIN_ARCHS=$arches"
+ target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_ARCHS=$arches -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_BUILTIN_ARCHS=$arches"
fi
build_flang="true"
|
boomanaiden154
approved these changes
Feb 14, 2025
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
This was broken when pgo was enabled by 0572580.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
This was broken when pgo was enabled by 0572580.
|
/cherry-pick d595d5a |
|
/pull-request #128945 |
sabitov-kirill
added a commit
to sabitov-kirill/llvm-project
that referenced
this pull request
Apr 2, 2025
* workflows/release-binaries-all: Add missing secret input (llvm#126921) Since d194c6b this workflow was missing the secret input which was causing it to fail. (cherry picked from commit a684e0e) * workflows/release-binaries: Fix macos-14 build (llvm#127157) This was broken when pgo was enabled by 0572580. (cherry picked from commit d595d5a) * [clang-format] Fix a bug that changes keyword `or` to an identifier (llvm#128410) Backports ffc61dc 0968df9 2d585cc Fixes llvm#105482 * [clangd] Add clangd 20 release notes (llvm#127358) * Bump version to 20.1.0 (final) * Add dummy "SystemS" target * Add barebone SystemS backend initislisation, that can succsesfully perform`CodeGenTargetMachineImpl::initAsmInfo`. Commit includes simplest form of registers, instructions, subtarget descrption. Commit includes simple lit test to check how far we can get in performing end-to-end compilation pipeline. * Add functional backend, that can emit basical asm * Add different testing scenarious * Add dag selection to pass config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken when pgo was enabled by
0572580.