Skip to content

AMDGPU: Add baseline tests for bitcast + readlane intrinsics #128493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Feb 24, 2025

No description provided.

Copy link
Contributor Author

arsenm commented Feb 24, 2025

@llvmbot
Copy link
Member

llvmbot commented Feb 24, 2025

@llvm/pr-subscribers-llvm-transforms

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/128493.diff

2 Files Affected:

  • (added) llvm/test/Transforms/InstCombine/AMDGPU/bitcast-fold-lane-ops.ll (+271)
  • (modified) llvm/test/Transforms/InstCombine/AMDGPU/permlane64.ll (+13-2)
diff --git a/llvm/test/Transforms/InstCombine/AMDGPU/bitcast-fold-lane-ops.ll b/llvm/test/Transforms/InstCombine/AMDGPU/bitcast-fold-lane-ops.ll
new file mode 100644
index 0000000000000..13347fd1a280e
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/AMDGPU/bitcast-fold-lane-ops.ll
@@ -0,0 +1,271 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 -passes=instcombine -S < %s | FileCheck %s
+
+define i32 @test_bitcast_f32_to_i32_readfirstlane(float %val) {
+; CHECK-LABEL: define i32 @test_bitcast_f32_to_i32_readfirstlane(
+; CHECK-SAME: float [[VAL:%.*]]) #[[ATTR0:[0-9]+]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast float [[VAL]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast = bitcast float %val to i32
+  %result = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+define i32 @test_bitcast_f32_to_i32_readfirstlane_multi_use_store(float %val, ptr %use.ptr) {
+; CHECK-LABEL: define i32 @test_bitcast_f32_to_i32_readfirstlane_multi_use_store(
+; CHECK-SAME: float [[VAL:%.*]], ptr [[USE_PTR:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast float [[VAL]] to i32
+; CHECK-NEXT:    store float [[VAL]], ptr [[USE_PTR]], align 4
+; CHECK-NEXT:    [[TMP1:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[TMP1]]
+;
+  %bitcast = bitcast float %val to i32
+  store i32 %bitcast, ptr %use.ptr
+  %result = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+declare void @use.i32(i32)
+
+define i32 @test_bitcast_f32_to_i32_readfirstlane_multi_use_call(float %val) {
+; CHECK-LABEL: define i32 @test_bitcast_f32_to_i32_readfirstlane_multi_use_call(
+; CHECK-SAME: float [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast float [[VAL]] to i32
+; CHECK-NEXT:    call void @use.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    [[TMP1:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[TMP1]]
+;
+  %bitcast = bitcast float %val to i32
+  call void @use.i32(i32 %bitcast)
+  %result = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+define float @test_bitcast_f32_to_i32_readfirstlane_bitcast(float %val) {
+; CHECK-LABEL: define float @test_bitcast_f32_to_i32_readfirstlane_bitcast(
+; CHECK-SAME: float [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast float [[VAL]] to i32
+; CHECK-NEXT:    [[CALL:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    [[RESULT:%.*]] = bitcast i32 [[CALL]] to float
+; CHECK-NEXT:    ret float [[RESULT]]
+;
+  %bitcast = bitcast float %val to i32
+  %call = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  %result = bitcast i32 %call to float
+  ret float %result
+}
+
+define i32 @test_bitcast_v2f16_to_i32_readfirstlane(<2 x half> %val) {
+; CHECK-LABEL: define i32 @test_bitcast_v2f16_to_i32_readfirstlane(
+; CHECK-SAME: <2 x half> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <2 x half> [[VAL]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast = bitcast <2 x half> %val to i32
+  %result = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+define i32 @test_bitcast_v2bf16_to_i32_readfirstlane(<2 x bfloat> %val) {
+; CHECK-LABEL: define i32 @test_bitcast_v2bf16_to_i32_readfirstlane(
+; CHECK-SAME: <2 x bfloat> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <2 x bfloat> [[VAL]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast = bitcast <2 x bfloat> %val to i32
+  %result = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+define i64 @test_bitcast_f64_to_i64_readfirstlane(double %val) {
+; CHECK-LABEL: define i64 @test_bitcast_f64_to_i64_readfirstlane(
+; CHECK-SAME: double [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast double [[VAL]] to i64
+; CHECK-NEXT:    [[RESULT:%.*]] = call i64 @llvm.amdgcn.readfirstlane.i64(i64 [[BITCAST]])
+; CHECK-NEXT:    ret i64 [[RESULT]]
+;
+  %bitcast = bitcast double %val to i64
+  %result = call i64 @llvm.amdgcn.readfirstlane.i64(i64 %bitcast)
+  ret i64 %result
+}
+
+define <2 x i32> @test_bitcast_f64_to_v2i32_readfirstlane(double %val) {
+; CHECK-LABEL: define <2 x i32> @test_bitcast_f64_to_v2i32_readfirstlane(
+; CHECK-SAME: double [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast double [[VAL]] to <2 x i32>
+; CHECK-NEXT:    [[RESULT:%.*]] = call <2 x i32> @llvm.amdgcn.readfirstlane.v2i32(<2 x i32> [[BITCAST]])
+; CHECK-NEXT:    ret <2 x i32> [[RESULT]]
+;
+  %bitcast = bitcast double %val to <2 x i32>
+  %result = call <2 x i32> @llvm.amdgcn.readfirstlane.v2i32(<2 x i32> %bitcast)
+  ret <2 x i32> %result
+}
+
+define i64 @test_bitcast_v4i16_to_i64_readfirstlane(<4 x i16> %val) {
+; CHECK-LABEL: define i64 @test_bitcast_v4i16_to_i64_readfirstlane(
+; CHECK-SAME: <4 x i16> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <4 x i16> [[VAL]] to i64
+; CHECK-NEXT:    [[RESULT:%.*]] = call i64 @llvm.amdgcn.readfirstlane.i64(i64 [[BITCAST]])
+; CHECK-NEXT:    ret i64 [[RESULT]]
+;
+  %bitcast = bitcast <4 x i16> %val to i64
+  %result = call i64 @llvm.amdgcn.readfirstlane.i64(i64 %bitcast)
+  ret i64 %result
+}
+
+
+define i32 @test_bitcast_v4i8_to_i32_readfirstlane(<4 x i8> %val) {
+; CHECK-LABEL: define i32 @test_bitcast_v4i8_to_i32_readfirstlane(
+; CHECK-SAME: <4 x i8> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <4 x i8> [[VAL]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast = bitcast <4 x i8> %val to i32
+  %result = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+define i32 @test_bitcast_v8i4_to_i32_readfirstlane(<8 x i4> %val) {
+; CHECK-LABEL: define i32 @test_bitcast_v8i4_to_i32_readfirstlane(
+; CHECK-SAME: <8 x i4> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <8 x i4> [[VAL]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.readfirstlane.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast = bitcast <8 x i4> %val to i32
+  %result = call i32 @llvm.amdgcn.readfirstlane.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+define float @test_bitcast_i32_to_f32_readfirstlane(i32 %val) {
+; CHECK-LABEL: define float @test_bitcast_i32_to_f32_readfirstlane(
+; CHECK-SAME: i32 [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast i32 [[VAL]] to float
+; CHECK-NEXT:    [[RESULT:%.*]] = call float @llvm.amdgcn.readfirstlane.f32(float [[BITCAST]])
+; CHECK-NEXT:    ret float [[RESULT]]
+;
+  %bitcast = bitcast i32 %val to float
+  %result = call float @llvm.amdgcn.readfirstlane.f32(float %bitcast)
+  ret float %result
+}
+
+define i16 @test_bitcast_f16_to_i16_readfirstlane(half %val) {
+; CHECK-LABEL: define i16 @test_bitcast_f16_to_i16_readfirstlane(
+; CHECK-SAME: half [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast half [[VAL]] to i16
+; CHECK-NEXT:    [[RESULT:%.*]] = call i16 @llvm.amdgcn.readfirstlane.i16(i16 [[BITCAST]])
+; CHECK-NEXT:    ret i16 [[RESULT]]
+;
+  %bitcast = bitcast half %val to i16
+  %result = call i16 @llvm.amdgcn.readfirstlane.i16(i16 %bitcast)
+  ret i16 %result
+}
+
+define i16 @test_bitcast_v2i8_to_i16_readfirstlane(<2 x i8> %val) {
+; CHECK-LABEL: define i16 @test_bitcast_v2i8_to_i16_readfirstlane(
+; CHECK-SAME: <2 x i8> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <2 x i8> [[VAL]] to i16
+; CHECK-NEXT:    [[RESULT:%.*]] = call i16 @llvm.amdgcn.readfirstlane.i16(i16 [[BITCAST]])
+; CHECK-NEXT:    ret i16 [[RESULT]]
+;
+  %bitcast = bitcast <2 x i8> %val to i16
+  %result = call i16 @llvm.amdgcn.readfirstlane.i16(i16 %bitcast)
+  ret i16 %result
+}
+
+define <16 x i32> @test_bitcast_v16f32_to_v16i32_readfirstlane(<16 x float> %val) {
+; CHECK-LABEL: define <16 x i32> @test_bitcast_v16f32_to_v16i32_readfirstlane(
+; CHECK-SAME: <16 x float> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <16 x float> [[VAL]] to <16 x i32>
+; CHECK-NEXT:    [[TMP1:%.*]] = call <16 x i32> @llvm.amdgcn.readfirstlane.v16i32(<16 x i32> [[BITCAST]])
+; CHECK-NEXT:    ret <16 x i32> [[TMP1]]
+;
+  %bitcast = bitcast <16 x float> %val to <16 x i32>
+  %result = call <16 x i32> @llvm.amdgcn.readfirstlane.v16i32(<16 x i32> %bitcast)
+  ret <16 x i32> %result
+}
+
+define <8 x i64> @test_bitcast_v16f32_to_v8i64_readfirstlane(<16 x float> %val) {
+; CHECK-LABEL: define <8 x i64> @test_bitcast_v16f32_to_v8i64_readfirstlane(
+; CHECK-SAME: <16 x float> [[VAL:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast <16 x float> [[VAL]] to <8 x i64>
+; CHECK-NEXT:    [[TMP1:%.*]] = call <8 x i64> @llvm.amdgcn.readfirstlane.v8i64(<8 x i64> [[BITCAST]])
+; CHECK-NEXT:    ret <8 x i64> [[TMP1]]
+;
+  %bitcast = bitcast <16 x float> %val to <8 x i64>
+  %result = call <8 x i64> @llvm.amdgcn.readfirstlane.v8i64(<8 x i64> %bitcast)
+  ret <8 x i64> %result
+}
+
+define i32 @test_bitcast_f32_to_i32_readlane(float %val, i32 inreg %lane.index) {
+; CHECK-LABEL: define i32 @test_bitcast_f32_to_i32_readlane(
+; CHECK-SAME: float [[VAL:%.*]], i32 inreg [[LANE_INDEX:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast float [[VAL]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.readlane.i32(i32 [[BITCAST]], i32 [[LANE_INDEX]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast = bitcast float %val to i32
+  %result = call i32 @llvm.amdgcn.readlane.i32(i32 %bitcast, i32 %lane.index)
+  ret i32 %result
+}
+
+define i32 @test_bitcast_f32_to_i32_writelane_samesourcetype(float %val0, i32 inreg %lane.index, float %val1) {
+; CHECK-LABEL: define i32 @test_bitcast_f32_to_i32_writelane_samesourcetype(
+; CHECK-SAME: float [[VAL0:%.*]], i32 inreg [[LANE_INDEX:%.*]], float [[VAL1:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST0:%.*]] = bitcast float [[VAL0]] to i32
+; CHECK-NEXT:    [[BITCAST1:%.*]] = bitcast float [[VAL1]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.writelane.i32(i32 [[BITCAST0]], i32 [[LANE_INDEX]], i32 [[BITCAST1]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast0 = bitcast float %val0 to i32
+  %bitcast1 = bitcast float %val1 to i32
+  %result = call i32 @llvm.amdgcn.writelane.i32(i32 %bitcast0, i32 %lane.index, i32 %bitcast1)
+  ret i32 %result
+}
+
+define i32 @test_bitcast_f32_to_i32_writelane_diffsourcetype(float %val0, i32 inreg %lane.index, <2 x half> %val1) {
+; CHECK-LABEL: define i32 @test_bitcast_f32_to_i32_writelane_diffsourcetype(
+; CHECK-SAME: float [[VAL0:%.*]], i32 inreg [[LANE_INDEX:%.*]], <2 x half> [[VAL1:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST0:%.*]] = bitcast float [[VAL0]] to i32
+; CHECK-NEXT:    [[BITCAST1:%.*]] = bitcast <2 x half> [[VAL1]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.writelane.i32(i32 [[BITCAST0]], i32 [[LANE_INDEX]], i32 [[BITCAST1]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast0 = bitcast float %val0 to i32
+  %bitcast1 = bitcast <2 x half> %val1 to i32
+  %result = call i32 @llvm.amdgcn.writelane.i32(i32 %bitcast0, i32 %lane.index, i32 %bitcast1)
+  ret i32 %result
+}
+
+define i32 @test_bitcast_update_dpp_f32_to_i32(float %val0, float %val1) {
+; CHECK-LABEL: define i32 @test_bitcast_update_dpp_f32_to_i32(
+; CHECK-SAME: float [[VAL0:%.*]], float [[VAL1:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST0:%.*]] = bitcast float [[VAL0]] to i32
+; CHECK-NEXT:    [[BITCAST1:%.*]] = bitcast float [[VAL1]] to i32
+; CHECK-NEXT:    [[TMP0:%.*]] = call i32 @llvm.amdgcn.update.dpp.i32(i32 [[BITCAST0]], i32 [[BITCAST1]], i32 1, i32 1, i32 1, i1 false)
+; CHECK-NEXT:    ret i32 [[TMP0]]
+;
+  %bitcast0 = bitcast float %val0 to i32
+  %bitcast1 = bitcast float %val1 to i32
+  %dpp = call i32 @llvm.amdgcn.update.dpp.i32(i32 %bitcast0, i32 %bitcast1, i32 1, i32 1, i32 1, i1 false)
+  ret i32 %dpp
+}
+
+define i32 @test_bitcast_update_dpp_sources_different_type(float %val0, <2 x half> %val1) {
+; CHECK-LABEL: define i32 @test_bitcast_update_dpp_sources_different_type(
+; CHECK-SAME: float [[VAL0:%.*]], <2 x half> [[VAL1:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[BITCAST0:%.*]] = bitcast float [[VAL0]] to i32
+; CHECK-NEXT:    [[BITCAST1:%.*]] = bitcast <2 x half> [[VAL1]] to i32
+; CHECK-NEXT:    [[TMP0:%.*]] = call i32 @llvm.amdgcn.update.dpp.i32(i32 [[BITCAST0]], i32 [[BITCAST1]], i32 1, i32 1, i32 1, i1 false)
+; CHECK-NEXT:    ret i32 [[TMP0]]
+;
+  %bitcast0 = bitcast float %val0 to i32
+  %bitcast1 = bitcast <2 x half> %val1 to i32
+  %dpp = call i32 @llvm.amdgcn.update.dpp.i32(i32 %bitcast0, i32 %bitcast1, i32 1, i32 1, i32 1, i1 false)
+  ret i32 %dpp
+}
diff --git a/llvm/test/Transforms/InstCombine/AMDGPU/permlane64.ll b/llvm/test/Transforms/InstCombine/AMDGPU/permlane64.ll
index 12506d17ef3d9..5eaab6107192e 100644
--- a/llvm/test/Transforms/InstCombine/AMDGPU/permlane64.ll
+++ b/llvm/test/Transforms/InstCombine/AMDGPU/permlane64.ll
@@ -6,8 +6,19 @@ define i32 @test_constant() {
 ; CHECK-LABEL: @test_constant(
 ; CHECK-NEXT:    ret i32 99
 ;
-  %call = call i32 @llvm.amdgcn.permlane64(i32 99)
+  %call = call i32 @llvm.amdgcn.permlane64.i32(i32 99)
   ret i32 %call
 }
 
-declare i32 @llvm.amdgcn.permlane64(i32)
+define i32 @test_bitcast_f32_to_i32_permlane64(float %val) {
+; CHECK-LABEL: @test_bitcast_f32_to_i32_permlane64(
+; CHECK-NEXT:    [[BITCAST:%.*]] = bitcast float [[VAL:%.*]] to i32
+; CHECK-NEXT:    [[RESULT:%.*]] = call i32 @llvm.amdgcn.permlane64.i32(i32 [[BITCAST]])
+; CHECK-NEXT:    ret i32 [[RESULT]]
+;
+  %bitcast = bitcast float %val to i32
+  %result = call i32 @llvm.amdgcn.permlane64.i32(i32 %bitcast)
+  ret i32 %result
+}
+
+declare i32 @llvm.amdgcn.permlane64.i32(i32)

Base automatically changed from users/arsenm/tti-fix-missing-const-isTypeLegal-getRegUsageForType to main February 24, 2025 12:08
@arsenm arsenm force-pushed the users/arsenm/amdgpu/instcombine-baseline-bitcast-readlane-tests branch from 5b2d253 to d5797aa Compare February 24, 2025 12:09
ret i32 %result
}

declare i32 @llvm.amdgcn.permlane64.i32(i32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need intrinsic declarations? Wasn't there a change to make them unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of yes and kind of no. It's canonically still printed, and removing it also breaks the auto-upgrade of tests if the type mangling changes

@arsenm arsenm force-pushed the users/arsenm/amdgpu/instcombine-baseline-bitcast-readlane-tests branch from d5797aa to 37c1083 Compare February 25, 2025 02:23
Copy link
Contributor Author

arsenm commented Feb 26, 2025

Merge activity

  • Feb 26, 2:22 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 2:22 AM EST: A user merged this pull request with Graphite.

@arsenm arsenm merged commit 29c5e42 into main Feb 26, 2025
11 checks passed
@arsenm arsenm deleted the users/arsenm/amdgpu/instcombine-baseline-bitcast-readlane-tests branch February 26, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants