-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[HLSL] XFAIL smoothstep.ll
and SV_GroupIndex.ll
SPIR-V backend tests
#136343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-backend-spir-v Author: Kaitlin Peng (kmpeng) ChangesTemporarily fixes #136049. SPIRV-Tools seems to have grown some capability checks for vulkan 1.3, which broke:
For now the fix is to XFAIL these tests to unblock the pipeline. Full diff: https://github.com/llvm/llvm-project/pull/136343.diff 2 Files Affected:
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
index 83caa62150cda..f5be558929b52 100644
--- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
+++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
@@ -1,6 +1,9 @@
; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
+; TODO: This test currently fails when --target-env vulkan1.3 is specified.
+; XFAIL: *
+
; CHECK-DAG: %[[#int:]] = OpTypeInt 32 0
; CHECK-DAG: %[[#ptr_Input_int:]] = OpTypePointer Input %[[#int]]
; CHECK-DAG: %[[#LocalInvocationIndex:]] = OpVariable %[[#ptr_Input_int]] Input
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
index e0e04dd0faf58..64f3287f43416 100644
--- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
+++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
@@ -1,6 +1,9 @@
; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
+; TODO: This test currently fails when --target-env vulkan1.3 is specified.
+; XFAIL: *
+
; Make sure SPIRV operation function calls for smoothstep are lowered correctly.
; CHECK-DAG: %[[#op_ext_glsl:]] = OpExtInstImport "GLSL.std.450"
|
s-perron
approved these changes
Apr 18, 2025
bogner
approved these changes
Apr 18, 2025
farzonl
reviewed
Apr 18, 2025
farzonl
approved these changes
Apr 18, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…sts (llvm#136343) When SPIRV-Tools is enabled, tests that specify the target environment `vulkan1.3` in the validation step fail. This is because SPIRV-Tools seems to have [grown some capability checks for vulkan 1.3](KhronosGroup/SPIRV-Tools@7e41c71). The failing tests are: - `CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll` - `CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll` For now, the fix is to XFAIL these tests to unblock the pipeline. Issue llvm#136344 tracks the long-term solution for this.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…sts (llvm#136343) When SPIRV-Tools is enabled, tests that specify the target environment `vulkan1.3` in the validation step fail. This is because SPIRV-Tools seems to have [grown some capability checks for vulkan 1.3](KhronosGroup/SPIRV-Tools@7e41c71). The failing tests are: - `CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll` - `CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll` For now, the fix is to XFAIL these tests to unblock the pipeline. Issue llvm#136344 tracks the long-term solution for this.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…sts (llvm#136343) When SPIRV-Tools is enabled, tests that specify the target environment `vulkan1.3` in the validation step fail. This is because SPIRV-Tools seems to have [grown some capability checks for vulkan 1.3](KhronosGroup/SPIRV-Tools@7e41c71). The failing tests are: - `CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll` - `CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll` For now, the fix is to XFAIL these tests to unblock the pipeline. Issue llvm#136344 tracks the long-term solution for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SPIRV-Tools is enabled, tests that specify the target environment
vulkan1.3
in the validation step fail. This is because SPIRV-Tools seems to have grown some capability checks for vulkan 1.3. The failing tests are:CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
For now, the fix is to XFAIL these tests to unblock the pipeline.
Issue #136344 tracks the long-term solution for this.