Skip to content

[clang-repl] disable tests on AIX (NFC) #153068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

kkwli
Copy link
Collaborator

@kkwli kkwli commented Aug 11, 2025

clang-repl is not supported on AIX. The tests added in 2444c4a are disabled for AIX.

@aadanen Please review. Somehow I cannot add you to the reviewer list.

@kkwli kkwli self-assigned this Aug 11, 2025
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Aug 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 11, 2025

@llvm/pr-subscribers-clang

Author: Kelvin Li (kkwli)

Changes

clang-repl is not supported on AIX. The tests added in 2444c4a are disabled for AIX.

@aadanen Please review. Somehow I cannot add you to the reviewer list.


Full diff: https://github.com/llvm/llvm-project/pull/153068.diff

3 Files Affected:

  • (modified) clang/test/Interpreter/bad_percent_command.cpp (+1)
  • (modified) clang/test/Interpreter/dynamic-library-bad-args.cpp (+1)
  • (modified) clang/test/Interpreter/help.cpp (+1)
diff --git a/clang/test/Interpreter/bad_percent_command.cpp b/clang/test/Interpreter/bad_percent_command.cpp
index 207570cac1873..95bebeab58d37 100644
--- a/clang/test/Interpreter/bad_percent_command.cpp
+++ b/clang/test/Interpreter/bad_percent_command.cpp
@@ -1,3 +1,4 @@
+// UNSUPPORTED: system-aix
 // RUN: cat %s | clang-repl 2>&1 | FileCheck %s
 %foobar
 // CHECK: Invalid % command "%foobar", use "%help" to list commands
diff --git a/clang/test/Interpreter/dynamic-library-bad-args.cpp b/clang/test/Interpreter/dynamic-library-bad-args.cpp
index f48a2657beacc..7684a8b746c91 100644
--- a/clang/test/Interpreter/dynamic-library-bad-args.cpp
+++ b/clang/test/Interpreter/dynamic-library-bad-args.cpp
@@ -1,3 +1,4 @@
+// UNSUPPORTED: system-aix
 // RUN: cat %s | clang-repl 2>&1 | FileCheck %s
 %lib
 // CHECK: %lib expects 1 argument: the path to a dynamic library
diff --git a/clang/test/Interpreter/help.cpp b/clang/test/Interpreter/help.cpp
index 70f114f4644e3..5573fb4284c65 100644
--- a/clang/test/Interpreter/help.cpp
+++ b/clang/test/Interpreter/help.cpp
@@ -1,3 +1,4 @@
+// UNSUPPORTED: system-aix
 // RUN: cat %s | clang-repl | FileCheck %s
 %help
 // CHECK: %help   list clang-repl %commands

@aadanen
Copy link
Contributor

aadanen commented Aug 11, 2025

This seems fine because it matches the undo test. I'm new though so I don't think I have the ability to approve this or give you permission to merge it.

Copy link
Member

@daltenty daltenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we have serious problems running the JIT, so clang-repl isn't going to work as expected on AIX

@kkwli
Copy link
Collaborator Author

kkwli commented Aug 12, 2025

This seems fine because it matches the undo test. I'm new though so I don't think I have the ability to approve this or give you permission to merge it.

@aadanen Thanks for the review.

@kkwli kkwli merged commit a9c5d33 into llvm:main Aug 12, 2025
11 checks passed
@kkwli kkwli deleted the disable-clang-repl-test-aix branch August 12, 2025 01:10
@DavidSpickett
Copy link
Collaborator

This is fine but consider marking them unsupported using clang/test/Interpreter/lit.local.cfg. Then it'll apply to all tests there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants