Skip to content

[mlir][linalg][test] Fix flaky test linalg-morph-category-ops.mlir #153080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

rupprecht
Copy link
Collaborator

@rupprecht rupprecht commented Aug 11, 2025

This is another followup to a test added in #148424 that I missed in #152805

This test runs mlir-opt %s | mlir-opt %s | FileCheck to test the round trip behavior, but the second command takes input from the pipe, not the lit test, so it should be mlir-opt %s | mlir-opt | FileCheck.

@rupprecht rupprecht added the skip-precommit-approval PR for CI feedback, not intended for review label Aug 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 11, 2025

@llvm/pr-subscribers-mlir

Author: Jordan Rupprecht (rupprecht)

Changes

This is another followup to a test added in #148424 that I missed in #152805


Full diff: https://github.com/llvm/llvm-project/pull/153080.diff

1 Files Affected:

  • (modified) mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir (+1-1)
diff --git a/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir b/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir
index 00602c4a36010..246902389bb9e 100644
--- a/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir
+++ b/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir
@@ -2,7 +2,7 @@
 // RUN: mlir-opt %s -linalg-morph-ops=named-to-category | FileCheck %s  --check-prefix=NAMED_TO_CATEGORY
 
 // RUN: mlir-opt %s -linalg-morph-ops=named-to-category |  \
-// RUN:   mlir-opt %s -linalg-morph-ops=category-to-generic | FileCheck %s  --check-prefix=CATEGORY_TO_GENERIC
+// RUN:   mlir-opt -linalg-morph-ops=category-to-generic | FileCheck %s  --check-prefix=CATEGORY_TO_GENERIC
 
 func.func @exp(%A : tensor<16x8xf32>, %B : tensor<16x8xf32>) ->  tensor<16x8xf32> {
   %exp = linalg.exp ins(%A : tensor<16x8xf32>) outs(%B :  tensor<16x8xf32>) -> tensor<16x8xf32>

@llvmbot
Copy link
Member

llvmbot commented Aug 11, 2025

@llvm/pr-subscribers-mlir-linalg

Author: Jordan Rupprecht (rupprecht)

Changes

This is another followup to a test added in #148424 that I missed in #152805


Full diff: https://github.com/llvm/llvm-project/pull/153080.diff

1 Files Affected:

  • (modified) mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir (+1-1)
diff --git a/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir b/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir
index 00602c4a36010..246902389bb9e 100644
--- a/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir
+++ b/mlir/test/Dialect/Linalg/linalg-morph-category-ops.mlir
@@ -2,7 +2,7 @@
 // RUN: mlir-opt %s -linalg-morph-ops=named-to-category | FileCheck %s  --check-prefix=NAMED_TO_CATEGORY
 
 // RUN: mlir-opt %s -linalg-morph-ops=named-to-category |  \
-// RUN:   mlir-opt %s -linalg-morph-ops=category-to-generic | FileCheck %s  --check-prefix=CATEGORY_TO_GENERIC
+// RUN:   mlir-opt -linalg-morph-ops=category-to-generic | FileCheck %s  --check-prefix=CATEGORY_TO_GENERIC
 
 func.func @exp(%A : tensor<16x8xf32>, %B : tensor<16x8xf32>) ->  tensor<16x8xf32> {
   %exp = linalg.exp ins(%A : tensor<16x8xf32>) outs(%B :  tensor<16x8xf32>) -> tensor<16x8xf32>

@rupprecht rupprecht merged commit d7b96fa into llvm:main Aug 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:linalg mlir skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants