-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[TOSA] Change EightK MaxScale to 256 #66536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This patch changes the MaxScale value for level EightK to 256. Also updated affected level check tests Signed-off-by: Tai Ly <[email protected]> Change-Id: Id9cffd5eb9053bb688196cd5b3b55b3ddd2a359c
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core ChangesThis patch changes the MaxScale value for level EightK to 256. Also updated affected level check tests Change-Id: Id9cffd5eb9053bb688196cd5b3b55b3ddd2a359cFull diff: https://github.com/llvm/llvm-project/pull/66536.diff 2 Files Affected:
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
index 6a5f2bd467dab51..52885e69c3924f2 100644
--- a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
+++ b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
@@ -86,7 +86,7 @@ struct tosa_level_t {
}
};
-static constexpr tosa_level_t TOSA_LEVEL_EIGHTK = {6, 8192, 8192, 64};
+static constexpr tosa_level_t TOSA_LEVEL_EIGHTK = {6, 8192, 8192, 256};
static constexpr tosa_level_t TOSA_LEVEL_NONE = {0, 0, 0, 0};
//===----------------------------------------------------------------------===//
diff --git a/mlir/test/Dialect/Tosa/level_check.mlir b/mlir/test/Dialect/Tosa/level_check.mlir
index 69b22888246bb93..e7fdf8af409b564 100644
--- a/mlir/test/Dialect/Tosa/level_check.mlir
+++ b/mlir/test/Dialect/Tosa/level_check.mlir
@@ -639,7 +639,7 @@ func.func @test_transpose_conv2d_stride_x(%arg0: tensor<1x32x32x8xf32>, %arg1: t
func.func @test_resize_scale_y(%arg0: tensor<1x32x32x8xf32>) -> tensor<1x64x64x8xf32> {
// expected-error@+1 {{'tosa.resize' op failed level check: scale_y_n/scale_y_d <= MAX_SCALE}}
- %1 = "tosa.resize"(%arg0) { scale = array<i64: 65, 1, 4, 2>, offset = array<i64: -1, -1>, border = array<i64: 1, 1>, mode = "BILINEAR"} :
+ %1 = "tosa.resize"(%arg0) { scale = array<i64: 257, 1, 4, 2>, offset = array<i64: -1, -1>, border = array<i64: 1, 1>, mode = "BILINEAR"} :
(tensor<1x32x32x8xf32>) -> tensor<1x64x64x8xf32>
return %1 : tensor<1x64x64x8xf32>
}
@@ -648,7 +648,7 @@ func.func @test_resize_scale_y(%arg0: tensor<1x32x32x8xf32>) -> tensor<1x64x64x8
func.func @test_resize_scale_x(%arg0: tensor<1x32x32x8xf32>) -> tensor<1x64x64x8xf32> {
// expected-error@+1 {{'tosa.resize' op failed level check: scale_x_n/scale_x_d <= MAX_SCALE}}
- %1 = "tosa.resize"(%arg0) { scale = array<i64: 4, 2, 65, 1>, offset = array<i64: -1, -1>, border = array<i64: 1, 1>, mode = "BILINEAR"} :
+ %1 = "tosa.resize"(%arg0) { scale = array<i64: 4, 2, 257, 1>, offset = array<i64: -1, -1>, border = array<i64: 1, 1>, mode = "BILINEAR"} :
(tensor<1x32x32x8xf32>) -> tensor<1x64x64x8xf32>
return %1 : tensor<1x64x64x8xf32>
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This patch changes the MaxScale value for level EightK to 256. Also updated affected level check tests Change-Id: Id9cffd5eb9053bb688196cd5b3b55b3ddd2a359c Signed-off-by: Tai Ly <[email protected]>
This patch changes the MaxScale value for level EightK to 256. Also updated affected level check tests Change-Id: Id9cffd5eb9053bb688196cd5b3b55b3ddd2a359c Signed-off-by: Tai Ly <[email protected]>
This patch changes the MaxScale value for level EightK to 256. Also updated affected level check tests Change-Id: Id9cffd5eb9053bb688196cd5b3b55b3ddd2a359c Signed-off-by: Tai Ly <[email protected]>
This patch changes the MaxScale value for level EightK to 256. Also updated affected level check tests
Change-Id: Id9cffd5eb9053bb688196cd5b3b55b3ddd2a359c