Skip to content

[AMDGPU][MC][GFX11] Always output wait_vdst and wait_exp #66610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perlfu merged 1 commit into from
Sep 22, 2023
Merged

[AMDGPU][MC][GFX11] Always output wait_vdst and wait_exp #66610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,21 +532,15 @@ void AMDGPUInstPrinter::printDefaultVccOperand(bool FirstOperand,
void AMDGPUInstPrinter::printWaitVDST(const MCInst *MI, unsigned OpNo,
const MCSubtargetInfo &STI,
raw_ostream &O) {
uint8_t Imm = MI->getOperand(OpNo).getImm();
if (Imm != 0) {
O << " wait_vdst:";
printU4ImmDecOperand(MI, OpNo, O);
}
O << " wait_vdst:";
printU4ImmDecOperand(MI, OpNo, O);
}

void AMDGPUInstPrinter::printWaitEXP(const MCInst *MI, unsigned OpNo,
const MCSubtargetInfo &STI,
raw_ostream &O) {
uint8_t Imm = MI->getOperand(OpNo).getImm();
if (Imm != 0) {
O << " wait_exp:";
printU4ImmDecOperand(MI, OpNo, O);
}
O << " wait_exp:";
printU4ImmDecOperand(MI, OpNo, O);
}

bool AMDGPUInstPrinter::needsImpliedVcc(const MCInstrDesc &Desc,
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/MC/AMDGPU/gfx11_asm_ldsdir.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ lds_direct_load v15 wait_vdst:1
// GFX11: lds_direct_load v15 wait_vdst:1 ; encoding: [0x0f,0x00,0x11,0xce]

lds_direct_load v16 wait_vdst:0
// GFX11: lds_direct_load v16 ; encoding: [0x10,0x00,0x10,0xce]
// GFX11: lds_direct_load v16 wait_vdst:0 ; encoding: [0x10,0x00,0x10,0xce]

lds_direct_load v17
// GFX11: lds_direct_load v17 ; encoding: [0x11,0x00,0x10,0xce]
// GFX11: lds_direct_load v17 wait_vdst:0 ; encoding: [0x11,0x00,0x10,0xce]

lds_param_load v1, attr0.x wait_vdst:15
// GFX11: lds_param_load v1, attr0.x wait_vdst:15 ; encoding: [0x01,0x00,0x0f,0xce]
Expand Down
Loading