Skip to content

Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC #66881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC #66881

wants to merge 1 commit into from

Conversation

brechtsanders
Copy link

Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC

@brechtsanders
Update Interpreter.h
b524ba2 
Fix build dllexport/dllimport issues when doing a shared build for Windows
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 20, 2023
@MaskRay MaskRay requested a review from mstorsjo November 5, 2023 23:50
@mstorsjo mstorsjo mentioned this pull request Nov 6, 2023
Merged
@mstorsjo
Copy link
Member

mstorsjo commented Nov 6, 2023

Thanks, I wasn't aware of this issue (I don't routinely try building with -DBUILD_SHARED_LIBS=ON, which I presume is what you've done to trigger this). See 592e935 for earlier context on this issue; therefore I'd prefer to fix this as I do in #71393; can you confirm if that change works for you as well?

@mstorsjo
Copy link
Member

mstorsjo commented Nov 7, 2023

This is superseded by #71393 which was merged now.

@mstorsjo
Copy link
Member

This is superseded by #71393 which was merged now.

I'll close this one for now, as I believe the issue has been fixed differently.

@mstorsjo mstorsjo closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstorsjo mstorsjo Awaiting requested review from mstorsjo

Assignees
No one assigned
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brechtsanders @mstorsjo @llvmbot