Skip to content

Avoid need for SLocEntryLoaded BitVector #67960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Avoid need for SLocEntryLoaded BitVector #67960

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9fde224
Avoid need for SLocEntryLoaded BitVector
ktf Sep 29, 2023
cb27b89
Update llvm/include/llvm/ADT/PagedVector.h
ktf Oct 2, 2023
578b13d
Update llvm/include/llvm/ADT/PagedVector.h
ktf Oct 2, 2023
9462c05
Update llvm/include/llvm/ADT/PagedVector.h
ktf Oct 2, 2023
cd3e760
Add test
ktf Oct 2, 2023
07b4679
Update clang/include/clang/Basic/SourceManager.h
ktf Oct 2, 2023
0770744
Use EXPECT_TRUE / EXPECT_FALSE
ktf Oct 3, 2023
9d14a34
Update clang/include/clang/Basic/SourceManager.h
ktf Oct 3, 2023
354653e
Update clang/include/clang/Basic/SourceManager.h
ktf Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions llvm/unittests/ADT/PagedVectorTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,20 @@ TEST(PagedVectorTest, FillNonTrivialConstructor) {
EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 10LL);
}

// Test that isMaterialized returns true for all the elements
// of the page, not only the one that was accessed.
TEST(PagedVectorTest, IsMaterialized) {
PagedVector<int, 10> V;
V.resize(20);
EXPECT_EQ(V.isMaterialized(0), false);
EXPECT_EQ(V.isMaterialized(1), false);
EXPECT_EQ(V.isMaterialized(10), false);
V[0] = 0;
EXPECT_EQ(V.isMaterialized(0), true);
EXPECT_EQ(V.isMaterialized(1), true);
EXPECT_EQ(V.isMaterialized(10), false);
}

// Elements are constructed, destructed in pages, so we expect
// the number of constructed / destructed elements to be a multiple of the
// page size and the constructor is invoked when the page is actually accessed
Expand Down