Skip to content

[mlir][openacc][NFC] Remove useless OptionalAttr with UnitAttr #68337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[mlir][openacc][NFC] Remove useless OptionalAttr with UnitAttr #68337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions flang/lib/Lower/OpenACC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2981,9 +2981,8 @@ genACC(Fortran::lower::AbstractConverter &converter,
std::stringstream routineOpName;
routineOpName << accRoutinePrefix.str() << routineCounter++;
auto routineOp = modBuilder.create<mlir::acc::RoutineOp>(
loc, routineOpName.str(), funcName, mlir::StringAttr{}, mlir::UnitAttr{},
mlir::UnitAttr{}, mlir::UnitAttr{}, mlir::UnitAttr{}, mlir::UnitAttr{},
mlir::UnitAttr{}, mlir::IntegerAttr{});
loc, routineOpName.str(), funcName, mlir::StringAttr{}, false, false,
false, false, false, false, mlir::IntegerAttr{});
Comment on lines +2984 to +2985
Copy link
Collaborator

@joker-eph joker-eph Oct 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit as I'm driving by.

We should "name" non-variable arguments, such as:

    loc, routineOpName.str(), funcName, /*bind_name=*/mlir::StringAttr{}, /*gang=*/false,
       /*worker=*/false, /*vector=*/false, /*seq=*/false, /*nohost=*/false,
      /*implicit=*/false, /*gangDim*/mlir::IntegerAttr{});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have a follow up patch that will update the operation creation.


for (const Fortran::parser::AccClause &clause : clauses.v) {
if (std::get_if<Fortran::parser::AccClause::Seq>(&clause.u)) {
Expand Down
12 changes: 6 additions & 6 deletions mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,12 +1563,12 @@ def OpenACC_RoutineOp : OpenACC_Op<"routine", [IsolatedFromAbove]> {
let arguments = (ins SymbolNameAttr:$sym_name,
SymbolNameAttr:$func_name,
OptionalAttr<StrAttr>:$bind_name,
OptionalAttr<UnitAttr>:$gang,
OptionalAttr<UnitAttr>:$worker,
OptionalAttr<UnitAttr>:$vector,
OptionalAttr<UnitAttr>:$seq,
OptionalAttr<UnitAttr>:$nohost,
OptionalAttr<UnitAttr>:$implicit,
UnitAttr:$gang,
UnitAttr:$worker,
UnitAttr:$vector,
UnitAttr:$seq,
UnitAttr:$nohost,
UnitAttr:$implicit,
OptionalAttr<APIntAttr>:$gangDim);

let extraClassDeclaration = [{
Expand Down