-
Notifications
You must be signed in to change notification settings - Fork 18.6k
[RISCV] Strip W suffix from ADDIW #68425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,11 +12,12 @@ | |
| // extended bits aren't consumed or because the input was already sign extended | ||
| // by an earlier instruction. | ||
| // | ||
| // Then it removes the -w suffix from addw, slliw and mulw instructions | ||
| // whenever all users are dependent only on the lower word of the result of the | ||
| // instruction. We do this only for addw, slliw, and mulw because the -w forms | ||
| // are less compressible: c.add and c.slli have a larger register encoding than | ||
| // their w counterparts, and there's no compressible version of mulw. | ||
| // Then it removes the -w suffix from opw instructions whenever all users are | ||
| // dependent only on the lower word of the result of the instruction. This is | ||
| // profitable for addw because c.add has a larger register encoding than c.addw. | ||
| // For the remaining opw instructions, there is no compressed w variant. This | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a c.addiw.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, need to fix comment. |
||
| // tramsform also has the side effect of making RV32 and RV64 codegen for 32 | ||
| // bit constants match which helps reduce check duplication in LIT tests. | ||
| // | ||
| //===---------------------------------------------------------------------===// | ||
|
|
||
|
|
@@ -661,8 +662,11 @@ bool RISCVOptWInstrs::stripWSuffixes(MachineFunction &MF, | |
| default: | ||
| continue; | ||
| case RISCV::ADDW: Opc = RISCV::ADD; break; | ||
| case RISCV::ADDIW: Opc = RISCV::ADDI; break; | ||
| case RISCV::MULW: Opc = RISCV::MUL; break; | ||
| case RISCV::SLLIW: Opc = RISCV::SLLI; break; | ||
| case RISCV::SRLIW: Opc = RISCV::SRLI; break; | ||
| case RISCV::SRAIW: Opc = RISCV::SRAI; break; | ||
| } | ||
|
|
||
| if (hasAllWUsers(MI, ST, MRI)) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was incorrect. c.mul was added with Zcb.