Skip to content

[mlir] Extend tests of SymbolTable::replaceAllSymbolUses. #68780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[mlir] Extend tests of SymbolTable::replaceAllSymbolUses. #68780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions mlir/unittests/IR/SymbolTableTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,14 @@ class ReplaceAllSymbolUsesTest : public ::testing::Test {
void SetUp() override {
::test::registerTestDialect(registry);
context = std::make_unique<MLIRContext>(registry);
builder = std::make_unique<OpBuilder>(context.get());
}

void testReplaceAllSymbolUses(ReplaceFnType replaceFn) {
// Set up IR and find func ops.
OwningOpRef<ModuleOp> module =
parseSourceString<ModuleOp>(kInput, context.get());
ASSERT_TRUE(module);
SymbolTable symbolTable(module.get());
auto opIterator = module->getBody(0)->getOperations().begin();
auto fooOp = cast<FunctionOpInterface>(opIterator++);
Expand All @@ -46,7 +48,7 @@ class ReplaceAllSymbolUsesTest : public ::testing::Test {
ASSERT_TRUE(succeeded(res));
ASSERT_TRUE(succeeded(verify(module.get())));

// Check that it got renamed.
// Check that callee of the call op got renamed.
bool calleeFound = false;
fooOp->walk([&](CallOpInterface callOp) {
StringAttr callee = callOp.getCallableForCallee()
Expand All @@ -56,13 +58,19 @@ class ReplaceAllSymbolUsesTest : public ::testing::Test {
calleeFound = true;
});
EXPECT_TRUE(calleeFound);

// Check that module attribute did *not* get renamed.
auto moduleAttr = (*module)->getAttrOfType<FlatSymbolRefAttr>("test.attr");
ASSERT_TRUE(moduleAttr);
EXPECT_EQ(moduleAttr.getValue(), StringRef("bar"));
}

std::unique_ptr<MLIRContext> context;
std::unique_ptr<OpBuilder> builder;

private:
constexpr static llvm::StringLiteral kInput = R"MLIR(
module {
module attributes { test.attr = @bar } {
test.conversion_func_op private @foo() {
"test.conversion_call_op"() { callee=@bar } : () -> ()
"test.return"() : () -> ()
Expand All @@ -81,7 +89,7 @@ TEST_F(ReplaceAllSymbolUsesTest, OperationInModuleOp) {
testReplaceAllSymbolUses([&](auto symbolTable, auto module, auto fooOp,
auto barOp) -> LogicalResult {
return symbolTable.replaceAllSymbolUses(
barOp, StringAttr::get(context.get(), "baz"), module);
barOp, builder->getStringAttr("baz"), module);
});
}

Expand All @@ -90,8 +98,7 @@ TEST_F(ReplaceAllSymbolUsesTest, StringAttrInModuleOp) {
testReplaceAllSymbolUses([&](auto symbolTable, auto module, auto fooOp,
auto barOp) -> LogicalResult {
return symbolTable.replaceAllSymbolUses(
StringAttr::get(context.get(), "bar"),
StringAttr::get(context.get(), "baz"), module);
builder->getStringAttr("bar"), builder->getStringAttr("baz"), module);
});
}

Expand All @@ -100,17 +107,17 @@ TEST_F(ReplaceAllSymbolUsesTest, OperationInModuleBody) {
testReplaceAllSymbolUses([&](auto symbolTable, auto module, auto fooOp,
auto barOp) -> LogicalResult {
return symbolTable.replaceAllSymbolUses(
barOp, StringAttr::get(context.get(), "baz"), &module->getRegion(0));
barOp, builder->getStringAttr("baz"), &module->getRegion(0));
});
}

TEST_F(ReplaceAllSymbolUsesTest, StringAttrInModuleBody) {
// Symbol as `StringAttr`, rename within module body.
testReplaceAllSymbolUses([&](auto symbolTable, auto module, auto fooOp,
auto barOp) -> LogicalResult {
return symbolTable.replaceAllSymbolUses(
StringAttr::get(context.get(), "bar"),
StringAttr::get(context.get(), "baz"), &module->getRegion(0));
return symbolTable.replaceAllSymbolUses(builder->getStringAttr("bar"),
builder->getStringAttr("baz"),
&module->getRegion(0));
});
}

Expand All @@ -119,7 +126,7 @@ TEST_F(ReplaceAllSymbolUsesTest, OperationInFuncOp) {
testReplaceAllSymbolUses([&](auto symbolTable, auto module, auto fooOp,
auto barOp) -> LogicalResult {
return symbolTable.replaceAllSymbolUses(
barOp, StringAttr::get(context.get(), "baz"), fooOp);
barOp, builder->getStringAttr("baz"), fooOp);
});
}

Expand All @@ -128,8 +135,7 @@ TEST_F(ReplaceAllSymbolUsesTest, StringAttrInFuncOp) {
testReplaceAllSymbolUses([&](auto symbolTable, auto module, auto fooOp,
auto barOp) -> LogicalResult {
return symbolTable.replaceAllSymbolUses(
StringAttr::get(context.get(), "bar"),
StringAttr::get(context.get(), "baz"), fooOp);
builder->getStringAttr("bar"), builder->getStringAttr("baz"), fooOp);
});
}

Expand Down