-
Notifications
You must be signed in to change notification settings - Fork 14.5k
[VPlan] Add initial anlysis to infer scalar type of VPValues. #69013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
22b23c7
30a8968
58b145e
d89b7d8
4ed3b6d
529805c
a75c562
1483f63
79bcce9
532d75e
5bbd764
74525ad
722cc3d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,226 @@ | ||
//===- VPlanAnalysis.cpp - Various Analyses working on VPlan ----*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "VPlanAnalysis.h" | ||
#include "VPlan.h" | ||
|
||
using namespace llvm; | ||
|
||
#define DEBUG_TYPE "vplan" | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPBlendRecipe *R) { | ||
Type *ResTy = inferScalarType(R->getIncomingValue(0)); | ||
for (unsigned I = 1, E = R->getNumIncomingValues(); I != E; ++I) { | ||
VPValue *Inc = R->getIncomingValue(I); | ||
assert(inferScalarType(Inc) == ResTy && | ||
"different types inferred for different incoming values"); | ||
CachedTypes[Inc] = ResTy; | ||
} | ||
return ResTy; | ||
} | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPInstruction *R) { | ||
switch (R->getOpcode()) { | ||
case Instruction::Select: { | ||
Type *ResTy = inferScalarType(R->getOperand(1)); | ||
VPValue *OtherV = R->getOperand(2); | ||
assert(inferScalarType(OtherV) == ResTy && | ||
"different types inferred for different operands"); | ||
CachedTypes[OtherV] = ResTy; | ||
return ResTy; | ||
} | ||
case VPInstruction::FirstOrderRecurrenceSplice: | ||
return inferScalarType(R->getOperand(0)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. infer and/or cache type of operand 1? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, thanks! |
||
default: | ||
break; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, this works w/o return nor unreachable at the end? Very well. Perhaps worth a comment. Switch below should be consistent, i.e., with an unreachable default but no return at the unreachable end. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated it to move the unreachable out of the switch here as well |
||
llvm_unreachable("Unhandled opcode!"); | ||
} | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPWidenRecipe *R) { | ||
unsigned Opcode = R->getOpcode(); | ||
switch (Opcode) { | ||
case Instruction::ICmp: | ||
case Instruction::FCmp: | ||
return IntegerType::get(Ctx, 1); | ||
case Instruction::UDiv: | ||
case Instruction::SDiv: | ||
case Instruction::SRem: | ||
case Instruction::URem: | ||
case Instruction::Add: | ||
case Instruction::FAdd: | ||
case Instruction::Sub: | ||
case Instruction::FSub: | ||
case Instruction::Mul: | ||
case Instruction::FMul: | ||
case Instruction::FDiv: | ||
case Instruction::FRem: | ||
case Instruction::Shl: | ||
case Instruction::LShr: | ||
case Instruction::AShr: | ||
case Instruction::And: | ||
case Instruction::Or: | ||
case Instruction::Xor: { | ||
Type *ResTy = inferScalarType(R->getOperand(0)); | ||
assert(ResTy == inferScalarType(R->getOperand(1)) && | ||
"types for both operands must match for binary op"); | ||
CachedTypes[R->getOperand(1)] = ResTy; | ||
return ResTy; | ||
} | ||
case Instruction::FNeg: | ||
case Instruction::Freeze: | ||
return inferScalarType(R->getOperand(0)); | ||
default: | ||
break; | ||
} | ||
|
||
// Type inferrence not implemented for opcode. | ||
fhahn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
LLVM_DEBUG(dbgs() << "LV: Found unhandled opcode: " | ||
<< Instruction::getOpcodeName(Opcode)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: better dump the whole underlying instruction than/in addition to only its opcode. nit: can dump them for other unhandled cases of VPInstruction and replicate recipe above and below. |
||
llvm_unreachable("Unhandled opcode!"); | ||
} | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPWidenCallRecipe *R) { | ||
auto &CI = *cast<CallInst>(R->getUnderlyingInstr()); | ||
return CI.getType(); | ||
} | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPWidenMemoryInstructionRecipe *R) { | ||
if (R->isStore()) | ||
return cast<StoreInst>(&R->getIngredient())->getValueOperand()->getType(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (Independent Thought) Should VPWidenMemoryInstructionRecipe use Underlying instead of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The store doesn't defined a value, should we make it unreachable here or return a void type? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added an assert, thanks! |
||
|
||
return cast<LoadInst>(&R->getIngredient())->getType(); | ||
} | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPWidenSelectRecipe *R) { | ||
Type *ResTy = inferScalarType(R->getOperand(1)); | ||
VPValue *OtherV = R->getOperand(2); | ||
assert(inferScalarType(OtherV) == ResTy && | ||
"different types inferred for different operands"); | ||
CachedTypes[OtherV] = ResTy; | ||
return ResTy; | ||
} | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPReplicateRecipe *R) { | ||
switch (R->getUnderlyingInstr()->getOpcode()) { | ||
case Instruction::Call: { | ||
unsigned CallIdx = R->getNumOperands() - (R->isPredicated() ? 2 : 1); | ||
return cast<Function>(R->getOperand(CallIdx)->getLiveInIRValue()) | ||
->getReturnType(); | ||
} | ||
case Instruction::UDiv: | ||
case Instruction::SDiv: | ||
case Instruction::SRem: | ||
case Instruction::URem: | ||
case Instruction::Add: | ||
case Instruction::FAdd: | ||
case Instruction::Sub: | ||
case Instruction::FSub: | ||
case Instruction::Mul: | ||
case Instruction::FMul: | ||
case Instruction::FDiv: | ||
case Instruction::FRem: | ||
case Instruction::Shl: | ||
case Instruction::LShr: | ||
case Instruction::AShr: | ||
case Instruction::And: | ||
case Instruction::Or: | ||
case Instruction::Xor: | ||
case Instruction::ICmp: | ||
case Instruction::FCmp: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the inferred type always i1 for ICmp/FCmp? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the type inference is for the scalar type only, which always should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be good to clarify that the type inferred is that of scalars/vector-elements. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed, thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ICmp and FCmp should return There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I missed this here,. updated, thanks! I also added a few other missing cases here, including GetElementPtr and added the type verification also the |
||
Type *ResTy = inferScalarType(R->getOperand(0)); | ||
assert(ResTy == inferScalarType(R->getOperand(1)) && | ||
"inferred types for operands of binary op don't match"); | ||
CachedTypes[R->getOperand(1)] = ResTy; | ||
return ResTy; | ||
} | ||
case Instruction::Trunc: | ||
case Instruction::SExt: | ||
case Instruction::ZExt: | ||
case Instruction::FPExt: | ||
case Instruction::FPTrunc: | ||
case Instruction::ExtractValue: | ||
return R->getUnderlyingInstr()->getType(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fall through? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, thanks! |
||
case Instruction::Freeze: | ||
case Instruction::FNeg: | ||
return inferScalarType(R->getOperand(0)); | ||
case Instruction::Load: | ||
return cast<LoadInst>(R->getUnderlyingInstr())->getType(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it matter that the underlying value is a LoadInst? Also supply the type of values being stored? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It's an extra consistency check.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
LoadInst deserves an extra consistency check that truncation and extends do not?
Stores cannot be reached indirectly, but one can query their type directly, and one did provide support for querying the type of a widened stores above and interleaved stored below. Treatment should be consistent regardless of how stores are handled (replicated, widened, interleaved). If querying the type of stores is forbidden, it should be documented. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The interface returns the type of the defined value of the inputs (the public interface computes the type for a VPValue). As stores won't define a result, no type can be queried for them. Does that make sense? |
||
default: | ||
break; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. switches with return/unreachable cases/default should be handled consistently. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be handled consistently now, by sinking |
||
} | ||
|
||
llvm_unreachable("Unhandled instruction"); | ||
} | ||
|
||
Type *VPTypeAnalysis::inferScalarType(const VPValue *V) { | ||
if (Type *CachedTy = CachedTypes.lookup(V)) | ||
return CachedTy; | ||
|
||
Type *ResultTy = nullptr; | ||
if (V->isLiveIn()) | ||
return V->getLiveInIRValue()->getType(); | ||
|
||
const VPRecipeBase *Def = V->getDefiningRecipe(); | ||
|
||
switch (Def->getVPDefID()) { | ||
case VPDef::VPCanonicalIVPHISC: | ||
case VPDef::VPFirstOrderRecurrencePHISC: | ||
case VPDef::VPReductionPHISC: | ||
case VPDef::VPWidenPointerInductionSC: | ||
// Handle header phi recipes, except VPWienIntOrFpInduction which needs | ||
// special handling due it being possibly truncated. | ||
ResultTy = cast<VPHeaderPHIRecipe>(Def) | ||
->getStartValue() | ||
->getLiveInIRValue() | ||
->getType(); | ||
break; | ||
case VPDef::VPWidenIntOrFpInductionSC: | ||
ResultTy = cast<VPWidenIntOrFpInductionRecipe>(Def)->getScalarType(); | ||
break; | ||
case VPDef::VPPredInstPHISC: | ||
case VPDef::VPScalarIVStepsSC: | ||
case VPDef::VPWidenPHISC: | ||
ResultTy = inferScalarType(Def->getOperand(0)); | ||
break; | ||
case VPDef::VPBlendSC: | ||
ResultTy = inferScalarType(cast<VPBlendRecipe>(Def)); | ||
break; | ||
case VPDef::VPInstructionSC: | ||
ResultTy = inferScalarType(cast<VPInstruction>(Def)); | ||
break; | ||
case VPDef::VPInterleaveSC: | ||
// TODO: Use info from interleave group. | ||
ResultTy = V->getUnderlyingValue()->getType(); | ||
break; | ||
case VPDef::VPReplicateSC: | ||
ResultTy = inferScalarType(cast<VPReplicateRecipe>(Def)); | ||
break; | ||
case VPDef::VPWidenSC: | ||
ResultTy = inferScalarType(cast<VPWidenRecipe>(Def)); | ||
break; | ||
case VPDef::VPWidenCallSC: | ||
ResultTy = inferScalarType(cast<VPWidenCallRecipe>(Def)); | ||
break; | ||
case VPDef::VPWidenCastSC: | ||
ResultTy = cast<VPWidenCastRecipe>(Def)->getResultType(); | ||
break; | ||
case VPDef::VPWidenGEPSC: | ||
ResultTy = PointerType::get(Ctx, 0); | ||
break; | ||
case VPDef::VPWidenMemoryInstructionSC: | ||
ResultTy = inferScalarType(cast<VPWidenMemoryInstructionRecipe>(Def)); | ||
break; | ||
case VPDef::VPWidenSelectSC: | ||
ResultTy = inferScalarType(cast<VPWidenSelectRecipe>(Def)); | ||
break; | ||
} | ||
assert(ResultTy && "could not infer type for the given VPValue"); | ||
CachedTypes[V] = ResultTy; | ||
return ResultTy; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
//===- VPlanAnalysis.h - Various Analyses working on VPlan ------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLVM_TRANSFORMS_VECTORIZE_VPLANANALYSIS_H | ||
#define LLVM_TRANSFORMS_VECTORIZE_VPLANANALYSIS_H | ||
|
||
#include "llvm/ADT/DenseMap.h" | ||
|
||
namespace llvm { | ||
|
||
class LLVMContext; | ||
class VPValue; | ||
class VPBlendRecipe; | ||
class VPInterleaveRecipe; | ||
class VPInstruction; | ||
class VPReductionPHIRecipe; | ||
class VPWidenRecipe; | ||
class VPWidenCallRecipe; | ||
class VPWidenCastRecipe; | ||
class VPWidenIntOrFpInductionRecipe; | ||
class VPWidenMemoryInstructionRecipe; | ||
struct VPWidenSelectRecipe; | ||
class VPReplicateRecipe; | ||
class Type; | ||
|
||
/// An analysis for type-inference for VPValues. | ||
/// It infers the scalar type for a given VPValue by bottom-up traversing | ||
/// through defining recipes until root nodes with known types are reached (e.g. | ||
/// live-ins or memory recipes). The types are then propagated top down through | ||
fhahn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// operations. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The cache cannot be flushed so any changes made to VPlan after invoking the analysis render it obsolete and a new analysis must be constructed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Extended comment, thanks! |
||
/// Note that the analysis caches the infered types. A new analysis object must | ||
fhahn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// be constructed once a VPlan has been modified in a way that invalidates any | ||
/// of the previously infered types. | ||
fhahn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
class VPTypeAnalysis { | ||
DenseMap<const VPValue *, Type *> CachedTypes; | ||
LLVMContext &Ctx; | ||
|
||
Type *inferScalarType(const VPBlendRecipe *R); | ||
Type *inferScalarType(const VPInstruction *R); | ||
Type *inferScalarType(const VPWidenCallRecipe *R); | ||
Type *inferScalarType(const VPWidenRecipe *R); | ||
Type *inferScalarType(const VPWidenIntOrFpInductionRecipe *R); | ||
Type *inferScalarType(const VPWidenMemoryInstructionRecipe *R); | ||
Type *inferScalarType(const VPWidenSelectRecipe *R); | ||
Type *inferScalarType(const VPReplicateRecipe *R); | ||
|
||
public: | ||
VPTypeAnalysis(LLVMContext &Ctx) : Ctx(Ctx) {} | ||
|
||
/// Infer the type of \p V. Returns the scalar type of \p V. | ||
Type *inferScalarType(const VPValue *V); | ||
}; | ||
|
||
} // end namespace llvm | ||
|
||
#endif // LLVM_TRANSFORMS_VECTORIZE_VPLANANALYSIS_H |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
//===----------------------------------------------------------------------===// | ||
|
||
#include "VPlan.h" | ||
#include "VPlanAnalysis.h" | ||
#include "llvm/ADT/STLExtras.h" | ||
#include "llvm/ADT/SmallVector.h" | ||
#include "llvm/ADT/Twine.h" | ||
|
@@ -738,7 +739,19 @@ void VPWidenRecipe::execute(VPTransformState &State) { | |
<< Instruction::getOpcodeName(Opcode)); | ||
llvm_unreachable("Unhandled instruction!"); | ||
} // end of switch. | ||
|
||
#if !defined(NDEBUG) | ||
// Verify that VPlan type inference results agree with the type of the | ||
// generated values. | ||
VPTypeAnalysis A(State.Builder.GetInsertBlock()->getContext()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Caching types is unhelpful and even harmful time-wise if a VPTypeAnalysis is built for every call of inferScalarType(). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do! |
||
for (unsigned Part = 0; Part < State.UF; ++Part) { | ||
assert(VectorType::get(A.inferScalarType(getVPSingleValue()), State.VF) == | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. VPWidenRecipe inherits from VPValue, suffice to use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue was that overloaded function resolution was picking the more specific call |
||
State.get(this, Part)->getType() && | ||
"infered type and type from generated instructions do not match"); | ||
fhahn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
#endif | ||
} | ||
|
||
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) | ||
void VPWidenRecipe::print(raw_ostream &O, const Twine &Indent, | ||
VPSlotTracker &SlotTracker) const { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can wait for separate subsequent patch: type of all header phi's should arguably be derived from their start value. If it gets truncated, let the start value be truncated in VPlan. Similar for DerivedIV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!