[lldb] Fix linking to libtinfo

[haampie]

LLVM detects when ncurses has a separate terminfo library, but linking to it
was broken in lldb since b663395 (LLVM 14) due
to a change of variables. This commit fixes that oversight.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Harmen Stoppels (haampie)

Changes

TERMINFO_LIB is defined nowhere

---

Full diff: https://github.com/llvm/llvm-project/pull/69458.diff

1 Files Affected:

• (modified) lldb/source/Core/CMakeLists.txt (+1-1)

diff --git a/lldb/source/Core/CMakeLists.txt b/lldb/source/Core/CMakeLists.txt
index d7b4f2587a98bf9..9073e3e9b2ee33d 100644
--- a/lldb/source/Core/CMakeLists.txt
+++ b/lldb/source/Core/CMakeLists.txt
@@ -12,7 +12,7 @@ set(LLDB_LIBEDIT_LIBS)
 if (LLDB_ENABLE_CURSES)
   list(APPEND LLDB_CURSES_LIBS ${PANEL_LIBRARIES} ${CURSES_LIBRARIES})
   if(LLVM_ENABLE_TERMINFO)
-    list(APPEND LLDB_CURSES_LIBS ${TERMINFO_LIB})
+    list(APPEND LLDB_CURSES_LIBS ${Terminfo_LIBRARIES})
   endif()
   if (LLVM_BUILD_STATIC)
     list(APPEND LLDB_CURSES_LIBS gpm)

[DavidSpickett]

I see that b663395 removed the variable, but I never saw this on a buildbot, must be a config we don't cover.

What build configuration hits this issue? Please make a note of that in the commit message for future reference.

[haampie]

It's basically the same issue as #25067. Happens when ncurses is configured with --with-termlib, which puts certain symbols that lldb uses in libtinfo. Relevant cmake defines are -DLLDB_ENABLE_CURSES=ON -DLLVM_ENABLE_TERMINFO=ON.

[DavidSpickett]

Ok now I understand.

So please add what you just wrote to the commit message/ PR description. It will help anyone fighting the same issue later.

[DavidSpickett]

And thanks for the patch, looks like the issue you linked was fixed, then would have been broken again for a time, and will now be fixed! All's well that ends well.

[haampie]

Updated the PR description. That's sufficient?

[eugeneswalker]

Thank you!

[DavidSpickett]

If you have the ability to merge, go ahead. Otherwise I can click the button for you.

[haampie]

I can't merge, feel free to do so!