Skip to content

[BOLT] Filter itrace from perf script mmap & task events #69585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jonathandavies-arm
Copy link
Contributor

perf2bolt launches a few perf script commands and stores the output in temporary files before processing the output and cleaning them up before it exits.

The command perf script --show-mmap-events outputs PERF_RECORD_MMAP2 and instruction tracing data but when processed it only looks for PERF_RECORD_MMAP2 and the instruction tracing data is ignored. This is fine for small amounts of instruction trace data but when I've recorded Arm ETM or Intel PT AUX I get lots of it

By adding --no-itrace is will just show the PERF_RECORD_MMAP2 records and will save on time running the perf script, disk space storing the output & time parsing the output.

It is the same for perf script --show-task-events where BOLT is only interested in the PERF_RECORD_COMM & PERF_RECORD_FORK records.

Data

Perf Record Perf Data Size MMap Size MMap No Itrace Size
perf record -e cs_etm/@tmc_etr0/u 137K 4468K 0.632K
perf record -e intel_pt//u 890K 33378K 0.673K

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

✅ With the latest revision this PR passed the C/C++ code formatter.

@jonathandavies-arm
Copy link
Contributor Author

@maksfb @rafaelauler Please can I have a review. I can't add the Bolt label myself yet.

Copy link
Contributor

@rafaelauler rafaelauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants