Skip to content

Fix comment in wasm unreachable test #70340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix comment in wasm unreachable test #70340

merged 1 commit into from
Oct 26, 2023

Conversation

majaha
Copy link
Contributor

@majaha majaha commented Oct 26, 2023

Some textual editing errors got through this pull request that was merged a few weeks ago: #65876

This patch clears up the unintentional duplicated line, and white-space at the end of the lines.

@llvmbot
Copy link
Member

llvmbot commented Oct 26, 2023

@llvm/pr-subscribers-backend-webassembly

Author: Matt Harding (majaha)

Changes

Some textual editing errors got through this pull request that was merged a few weeks ago: #65876

This patch clears up the unintentional duplicated line, and white-space at the end of the lines.


Full diff: https://github.com/llvm/llvm-project/pull/70340.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/WebAssembly/unreachable.ll (+4-5)
diff --git a/llvm/test/CodeGen/WebAssembly/unreachable.ll b/llvm/test/CodeGen/WebAssembly/unreachable.ll
index 72f865842bdcaa5..5368c2ba5b8dc1c 100644
--- a/llvm/test/CodeGen/WebAssembly/unreachable.ll
+++ b/llvm/test/CodeGen/WebAssembly/unreachable.ll
@@ -80,11 +80,10 @@ define i32 @missing_ret_unreachable() {
   unreachable
 }
 
-; This is similar to the above test, but ensures wasm unreachable is emitted
-; This is similar to the above test, but the callee has a 'noreturn' attribute.    
-; There is an optimization that removes an 'unreachable' after a noreturn call,  
-; but Wasm backend doesn't use it and ignore `--no-trap-after-noreturn`, if      
-; given, to generate valid code. 
+; This is similar to the above test, but the callee has a 'noreturn' attribute.
+; There is an optimization that removes an 'unreachable' after a noreturn call,
+; but Wasm backend doesn't use it and ignore `--no-trap-after-noreturn`, if
+; given, to generate valid code.
 define i32 @missing_ret_noreturn_unreachable() {
 ; CHECK-LABEL: missing_ret_noreturn_unreachable:
 ; CHECK:         .functype missing_ret_noreturn_unreachable () -> (i32)

@dschuff dschuff merged commit bf92eba into llvm:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants