[JITLink][AArch32] Add support for ELF::R_ARM_THM_MOV{W_PREL_NC,T_PREL} #70364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Though not dependent, assumes PR #70346 being merged. |
eymay
changed the title
eymay
force-pushed
the
jitlink-thumb-movwprel
branch
2 times, most recently
from
9f39f51 to
665de0a
Compare
weliveindetail
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Thanks, this LGTM! It would be good to land this patch and work on the remarks from my inline comments in context of my upcoming PR #71649
| @@ -377,12 +377,14 @@ Expected<int64_t> readAddendThumb(LinkGraph &G, Block &B, const Edge &E, | |||
| : decodeImmBT4BlT1BlxT2(R.Hi, R.Lo); | |||
|
|
|||
| case Thumb_MovwAbsNC: | |||
| case Thumb_MovwPrelNC: | |||
There was a problem hiding this comment.
We were talking about the opcode checks and duplication in both, code and constants. I've been working on a patch to compensate for it here: #71649 With that the asymmetry in opcode checks will go away. I think we can land this as is.
llvm/test/ExecutionEngine/JITLink/AArch32/ELF_static_thumb_reloc.s
Outdated
Show resolved
Hide resolved
Support for ELF::R_ARM_THM_MOVW_PREL_NC and ELF::R_ARM_THM_MOVT_PREL is added. Move instructions with PC-relative immediates can be handled in Thumb mode with this addition.
eymay
force-pushed
the
jitlink-thumb-movwprel
branch
from
665de0a to
56aa89f
Compare
weliveindetail
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for ELF::R_ARM_THM_MOVW_PREL_NC and ELF::R_ARM_THM_MOVT_PREL
is added. Move instructions with PC-relative immediates can be handled in Thumb mode with this addition.