Skip to content

[lldb][progress] Always report progress upon Progress object destruction #73605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chelcassanova merged 2 commits into from
Nov 28, 2023
Merged

[lldb][progress] Always report progress upon Progress object destruction #73605

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c29a20
[lldb][progress] Always report progress upon Progress object destruction
chelcassanova Nov 27, 2023
67f5039
fixup! [lldb][progress] Always report progress upon Progress object d…
chelcassanova Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Core/Progress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ Progress::~Progress() {
std::lock_guard<std::mutex> guard(m_mutex);
if (!m_completed) {
m_completed = m_total;
ReportProgress();
}
Copy link
Member

@medismailben medismailben Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the braces: https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

ReportProgress();
}

void Progress::Increment(uint64_t amount, std::string update) {
Expand Down