[memprof][NFC] Free symbolizer memory eagerly #75849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the ownership of the symbolizer into symbolizeAndFilterStackFrames so that it is freed on exit, when we are done with it, to reduce peak memory in the reader. This reduces about 9G from the peak for one large profile.
|
Fixed version of PR75119, which got very messed up after some kind of bad merge. |
snehasish
approved these changes
Dec 18, 2023
| @@ -344,7 +344,7 @@ Error RawMemProfReader::initialize(std::unique_ptr<MemoryBuffer> DataBuffer) { | |||
| Object, std::move(Context), /*UntagAddresses=*/false); | |||
| if (!SOFOr) | |||
| return report(SOFOr.takeError(), FileName); | |||
| Symbolizer = std::move(SOFOr.get()); | |||
| auto Symbolizer = std::move(SOFOr.get()); | |||
There was a problem hiding this comment.
I wonder if it makes a difference to the peak memory usage if we move L343-L347 after the readRawRawProfile call. That would mean that we initialize the Symbolizer after we free the raw profile data buffer.
There was a problem hiding this comment.
Yeah that's a good idea. In fact, we can move it after setupForSymbolization(), although I don't think there is a memory savings from doing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the ownership of the symbolizer into symbolizeAndFilterStackFrames
so that it is freed on exit, when we are done with it, to reduce peak
memory in the reader. This reduces about 9G from the peak for one large
profile.