Skip to content

[mlir][ArmSME] Workaround for old versions of GCC (NFC) #78046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions mlir/lib/Conversion/ArmSMEToLLVM/ArmSMEToLLVM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -364,29 +364,31 @@ struct ConvertArmSMEOpToLLVMPattern : ConvertOpToLLVMPattern<SourceOp> {
}
};

template <typename Pattern>
static void addArmSMEConversionPattern(RewritePatternSet &patterns,
LLVMTypeConverter const &typeConverter) {
// Register spills/fills for ops that implement the
// `ArmSMETileOpInterface` and have `requiresSpillsAndFills` set to
// `RequiresSpillsAndFills::Yes`.
if constexpr (Pattern::requiresSpillsAndFillsConversion() &&
std::is_base_of_v<arm_sme::ArmSMETileOpInterface::Trait<
typename Pattern::ArmSMEOp>,
typename Pattern::ArmSMEOp>) {
// Add spill/fill conversions with a very high benefit to ensure
// they are lowered first.
patterns.add<ConvertArmSMESpillsAndFillsToLLVM>(
Pattern::ArmSMEOp::getOperationName(), typeConverter,
/*benefit=*/1337);
}
patterns.add<Pattern>(typeConverter);
}

/// Helper to register `ConvertArmSMEOpToLLVMPattern` patterns.
template <typename... Pattern>
template <typename... Patterns>
static void
addArmSMEConversionPatterns(RewritePatternSet &patterns,
LLVMTypeConverter const &typeConverter) {
(
[&] {
// Register spills/fills for ops that implement the
// `ArmSMETileOpInterface` and have `requiresSpillsAndFills` set to
// `RequiresSpillsAndFills::Yes`.
if constexpr (Pattern::requiresSpillsAndFillsConversion() &&
std::is_base_of_v<arm_sme::ArmSMETileOpInterface::Trait<
typename Pattern::ArmSMEOp>,
typename Pattern::ArmSMEOp>) {
// Add spill/fill conversions with a very high benefit to ensure
// they are lowered first.
patterns.add<ConvertArmSMESpillsAndFillsToLLVM>(
Pattern::ArmSMEOp::getOperationName(), typeConverter,
/*benefit=*/1337);
}
patterns.add<Pattern>(typeConverter);
}(),
...);
(addArmSMEConversionPattern<Patterns>(patterns, typeConverter), ...);
}

struct GetTileConversion
Expand Down