Skip to content

[Flang][OpenMP] Install omp_lib*.{mod,h} into correct resource directory for standalone Flang builds #90888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mjklemm
Copy link
Contributor

@mjklemm mjklemm commented May 2, 2024

Fixes #90543. Depends PR #90886 as it relies on -print-resource-dir.

@mjklemm mjklemm requested review from tblah, jdoerfert and jpeyton52 May 2, 2024 18:46
@mjklemm mjklemm self-assigned this May 2, 2024
@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels May 2, 2024
@mjklemm
Copy link
Contributor Author

mjklemm commented May 2, 2024

I have found one more bug in all this, where the .so file for the OpenMP runtime is not correctly installed.

@pawosm-arm
Copy link
Contributor

I have found one more bug in all this, where the .so file for the OpenMP runtime is not correctly installed.

Yes, this was annoying issue I've encountered too. To address this, I'm passing -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=Off to CMake when building LLVM with the OpenMP runtime.

@mjklemm mjklemm closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone Flang build Not building omp_lib.mod on M1 Mac
3 participants