-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[lldb] Added Debuginfod tests and fixed a couple issues #92572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
clayborg
merged 12 commits into
llvm:main
from
kevinfrei:debuginfod-tests-curl-dependent
May 22, 2024
Merged
[lldb] Added Debuginfod tests and fixed a couple issues #92572
clayborg
merged 12 commits into
llvm:main
from
kevinfrei:debuginfod-tests-curl-dependent
May 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7fc2fbb.
…Arch64/Arm buildbots
clayborg
approved these changes
May 22, 2024
This broke the Fuchsia CI builders' LLDB test suite:
|
mysterymath
added a commit
that referenced
this pull request
May 22, 2024
…)" This reverts commit e558d21.
mysterymath
added a commit
that referenced
this pull request
May 22, 2024
) Reverts #92572 due to Fuchsia CI breakages (using CLI tools in tests that weren't necessarily built).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go with attempt number five. Again, no changes to the LLDB code diff, which has been reviewed several times.
For the tests, I added a
@skipIfCurlSupportMissing
annotation so that the Debuginfod mocked server stuff won't run, and I also disabled non-Linux/FreeBSD hosts altogether, as they fail for platform reasons on macOS and Windows. In addition, I updated the process for extracting the GNU BuildID to no create a target, per some feedback on the previous diff.For reference, previous PR's (landed, backed out after the fact for various reasons) #90622, #87676, #86812, #85693