[cross-project-tests] Use "is" instead of "==" to check for None #94016
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
from
85990bc to
4f968ef
Compare
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
from
4f968ef to
73a316d
Compare
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
2 times, most recently
from
4ff2405 to
447b138
Compare
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
from
447b138 to
af90ab2
Compare
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
from
af90ab2 to
b7b57d4
Compare
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
from
b7b57d4 to
ea086bd
Compare
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
from
ea086bd to
d678e72
Compare
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or > is not, never the equality operators.
e-kwsm
force-pushed
the
cross-project-tests/E711
branch
from
d678e72 to
39202c7
Compare
nikic
changed the title
|
@e-kwsm Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
…m#94016) From PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators.
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):