Skip to content

[PowerPC] Mark llvm.tan on vectors as expand #95507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[PowerPC] Mark llvm.tan on vectors as expand #95507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/lib/Target/PowerPC/PPCISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,7 @@ PPCTargetLowering::PPCTargetLowering(const PPCTargetMachine &TM,
setOperationAction(ISD::FEXP2, VT, Expand);
setOperationAction(ISD::FSIN, VT, Expand);
setOperationAction(ISD::FCOS, VT, Expand);
setOperationAction(ISD::FTAN, VT, Expand);
Copy link
Collaborator

@chenzheng1030 chenzheng1030 Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle STRICT_FTAN too?

Copy link
Member Author

@ecnelises ecnelises Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already been handled by common logic, and there's already been test for constrained tan in vector-constrained-fp-intrinsics.ll

setOperationAction(ISD::FABS, VT, Expand);
setOperationAction(ISD::FFLOOR, VT, Expand);
setOperationAction(ISD::FCEIL, VT, Expand);
Expand Down
9 changes: 9 additions & 0 deletions llvm/test/CodeGen/PowerPC/lower-intrinsics-nofast-mass.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,3 +145,12 @@ entry:
%0 = tail call double @llvm.sin.f64(double %a)
ret double %0
}

define <2 x double> @tan_v2f64_nofast(<2 x double> %a) {
; CHECK-LABEL: tan_v2f64_nofast
; CHECK-NOT: bl __xl_tan
; CHECK: blr
entry:
%0 = tail call <2 x double> @llvm.tan.v2f64(<2 x double> %a)
ret <2 x double> %0
}