Replace distutils.version with packaging.version since the former was deprecated in python 3.10 and removed in 3.12. #99852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deprecated in python 3.10 and removed in 3.12.
JDevlieghere
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to reland #99549, but using packaging.version instead of looseversion, based on the usage used for LLDB in #93712.
@JDevlieghere and @mysterymath I believe this should already be fine for your bots because you already have the packaging package installed for LLDB correct?
@tlively I used this attempt to reland the change to restructure it as was suggested in #99549 to limit the scope of the import until it is needed.
I have tested this manually on both of my cross-project-test bots, and both pass once I installed the packaging package.