Skip to content

[libc] Add working entrypoints to riscv #99885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mikhailramalho
Copy link
Member

Added new fsqrt entrypoints and updated headers.txt, which I missed in PR #99771

Added new fsqrt entrypoints and updated headers.txt, which I missed in
PR llvm#99771
@llvmbot
Copy link
Member

llvmbot commented Jul 22, 2024

@llvm/pr-subscribers-libc

Author: Mikhail R. Gadelha (mikhailramalho)

Changes

Added new fsqrt entrypoints and updated headers.txt, which I missed in PR #99771


Full diff: https://github.com/llvm/llvm-project/pull/99885.diff

2 Files Affected:

  • (modified) libc/config/linux/riscv/entrypoints.txt (+3)
  • (modified) libc/config/linux/riscv/headers.txt (+4-3)
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 6c557b7a69cb6..ea08957f4ee89 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -449,6 +449,8 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.fromfpx
     libc.src.math.fromfpxf
     libc.src.math.fromfpxl
+    libc.src.math.fsqrt
+    libc.src.math.fsqrtl
     libc.src.math.hypot
     libc.src.math.hypotf
     libc.src.math.ilogb
@@ -575,6 +577,7 @@ if(LIBC_TYPES_HAS_FLOAT128)
     libc.src.math.frexpf128
     libc.src.math.fromfpf128
     libc.src.math.fromfpxf128
+    libc.src.math.fsqrtf128
     libc.src.math.ilogbf128
     libc.src.math.ldexpf128
     libc.src.math.llogbf128
diff --git a/libc/config/linux/riscv/headers.txt b/libc/config/linux/riscv/headers.txt
index 4bb8d23ab961a..0294f62bc2f7a 100644
--- a/libc/config/linux/riscv/headers.txt
+++ b/libc/config/linux/riscv/headers.txt
@@ -2,6 +2,7 @@ set(TARGET_PUBLIC_HEADERS
     libc.include.assert
     libc.include.ctype
     libc.include.dirent
+    libc.include.dlfcn
     libc.include.errno
     libc.include.fcntl
     libc.include.features
@@ -18,6 +19,7 @@ set(TARGET_PUBLIC_HEADERS
     libc.include.setjmp
     libc.include.stdckdint
     libc.include.stdbit
+    libc.include.stdfix
     libc.include.stdio
     libc.include.stdlib
     libc.include.string
@@ -33,13 +35,12 @@ set(TARGET_PUBLIC_HEADERS
     libc.include.arpa_inet
 
     libc.include.sys_auxv
-    # Disabled due to epoll_wait syscalls not being available on this platform.
-    # libc.include.sys_epoll
+    libc.include.sys_epoll
     libc.include.sys_ioctl
     libc.include.sys_mman
     libc.include.sys_prctl
-    libc.include.sys_random
     libc.include.sys_queue
+    libc.include.sys_random
     libc.include.sys_resource
     libc.include.sys_select
     libc.include.sys_socket

@mikhailramalho mikhailramalho merged commit 28e6095 into llvm:main Jul 22, 2024
6 of 7 checks passed
@mikhailramalho mikhailramalho deleted the enable-rv-entrypoints branch July 22, 2024 15:06
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary: Added new fsqrt entrypoints and updated headers.txt, which I missed in PR #99771

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants