[TorchToLinalg] Upcast low precision dtypes for direct backward conv lowering #4408
+188
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zjgarvey <[email protected]>
zjgarvey
requested review from
IanWood1 and
a-sidorova
and removed request for
a-sidorova
IanWood1
reviewed
Dec 15, 2025
Signed-off-by: zjgarvey <[email protected]>
a-sidorova
approved these changes
Dec 16, 2025
Collaborator
a-sidorova
left a comment
a-sidorova
left a comment
There was a problem hiding this comment.
@zjgarvey thank you for quick fix!
Signed-off-by: zjgarvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer direct lowering for backward conv is directly accumulating lower precision types like bf16. This patch adds a check for the default accumulator type. If this type doesn't match the result types for the op, it will also introduce a downcasting elementwise op (post-convolution and pre-collapsing for groups).