Skip to content

Conversation

@danielcharrua
Copy link

On restart if GPIO is touched the device will enter on "serial config mode".
Also added a .gitignore to work more comfortable with vscode and Mac when pushing changes.

@AxelHamburch
Copy link

I have tested it, it works. Pin 4 to activate the "Launch portal" or now "Launch serial config" was the missing access.

@AxelHamburch
Copy link

It does not work, you have to choose another variant.

@danielcharrua
Copy link
Author

@AxelHamburch can you explain? This PR adds an old feature that was deprecated (I think @arcbtc explained why in the telegram group). When I touch pin 4 the device enters in serial config mode, but this has nothing to do with the browser serial.

If this PR is not addressing the issue you can discard it, no worries!

@dni dni force-pushed the add-serial-config branch from 99c220e to 18f4c96 Compare August 30, 2023 05:45
@dni dni requested review from arcbtc and blackcoffeexbt August 30, 2023 05:46
@dni dni force-pushed the add-serial-config branch 2 times, most recently from 20a4d64 to 34d03ad Compare August 30, 2023 06:30
@arcbtc
Copy link
Member

arcbtc commented Aug 30, 2023

I deleted this code, because it does nothing, only get in the way of using gpio4

@danielcharrua
Copy link
Author

@arcbtc how do you load the json config if not enabling the serial config mode on the device? We were talking these past days on Telegram but nobody answered that 🫠

@arcbtc
Copy link
Member

arcbtc commented Aug 30, 2023

I'd like @motorina0 to take a look, as I think the fix is the memory gets wiped before uploading new config. As far as I am aware this code is redundant.

@motorina0
Copy link

@danielcharrua I need a bit of help here. Can you please specify:

Summary

  • what the problem was

Steps:

  1. start the device...
  2. ....

Actual Result:

  • ...

Expected Result:

  • ... (what this fix does)

@motorina0 motorina0 self-requested a review September 5, 2023 12:16
@dni dni self-requested a review September 12, 2023 12:00
@dni dni merged commit b0d7cfb into lnbits:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants