Skip to content

Conversation

@shikanime
Copy link
Contributor

@shikanime shikanime commented Mar 21, 2025

No description provided.

Copy link

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zerbitx zerbitx self-requested a review March 26, 2025 12:37
Copy link

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to add these build args to the devspace.yaml under images.provider That will end up looking like this. You can verify its working by trying devspace deploy -p deploy. Thanks!

images:
  provider:
    image: ${IMAGE}
    buildArgs:
     TARGETOS: linux
     TARGETARCH: amd64
    rebuildStrategy: ignoreContextChanges
    docker: {}
    target: builder

@shikanime
Copy link
Contributor Author

shikanime commented Apr 17, 2025

@zerbitx is there anything else I should check ? I'm not entirely familiar with devspace but I might check it out sometime.

@zerbitx zerbitx requested a review from johannesfrey May 5, 2025 13:18
Copy link

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johannesfrey
Copy link
Contributor

@shikanime Thx for your contribution and @zerbitx thx for the review!

@johannesfrey johannesfrey merged commit 32a9704 into loft-sh:main May 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants