chore(deps): bump github.com/loft-sh/vcluster to 0.15.0 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the other dep bumps are a direct result of bumping vcluster. Except for the default chart version all code changes were forced by breaking changes in the dependencies.
Author
|
If this PR is accepted it would be great if it would be followed by a new release. |
Member
|
@yhrn thanks a lot for the PR! Sorry for letting this hang so long, LGTM! |
FabianKramm
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other dep bumps are a direct result of bumping vcluster. Except for the default chart version all code changes were forced by breaking changes in the dependencies.
The vendoring makes this PR huge but I don't see any other way of doing this. I have tested that with this change creating a k8s vCluster v0.15.0 (Kubernetes v1.26.1) works when using Helm v3.11.1.