chore(deps): upgrade {logger, go version, linters} #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasK33
suggested changes
Feb 20, 2024
Contributor
ThomasK33
left a comment
ThomasK33
left a comment
There was a problem hiding this comment.
The log messages aren't structured logs and as such won't work/display correctly.
You'll need to refactor them to be more like shown here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/3077-contextual-logging/README.md
ThomasK33
reviewed
Feb 20, 2024
Co-authored-by: Thomas Kosiewski <[email protected]>
narcis96
changed the title
narcis96
changed the title
ThomasK33
suggested changes
Feb 22, 2024
Contributor
ThomasK33
left a comment
ThomasK33
left a comment
There was a problem hiding this comment.
Looks good, just a couple of remarks regarding logging and levels.
Once those are fixed, this can be merged.
ThomasK33
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step 3 as part of Ref ENG-2850: