chore: Switch libnegentropy library build from shared to static linkage#3041
Merged
NagyZoltanPeter merged 3 commits intomasterfrom Sep 18, 2024
Merged
chore: Switch libnegentropy library build from shared to static linkage#3041NagyZoltanPeter merged 3 commits intomasterfrom
NagyZoltanPeter merged 3 commits intomasterfrom
Conversation
NagyZoltanPeter
requested review from
Ivansete-status,
SionoiS and
chaitanyaprem
|
You can find the image built from this PR at Built from 5100fe9 |
chaitanyaprem
approved these changes
Sep 18, 2024
Contributor
chaitanyaprem
left a comment
chaitanyaprem
left a comment
There was a problem hiding this comment.
LGTM, using this branch i was able to build and run docker image in my orangepi ubuntu which was failing before.
Ivansete-status
approved these changes
Sep 18, 2024
Collaborator
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
LGTM! Thanks for it! 💯
jm-clius
approved these changes
Sep 18, 2024
Contributor
jm-clius
left a comment
jm-clius
left a comment
There was a problem hiding this comment.
No objections from my side.
…d static build of libnegentropy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to various link issues with libnegentropy build as shared object, this PR is an experimental/proposal to switch to static linkage.
Changes