Skip to content

chore: Changed lib build from shared object to archive for linux #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagyZoltanPeter merged 2 commits into from
Sep 18, 2024
Merged

chore: Changed lib build from shared object to archive for linux #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47fb555
Changed lib build from shared object to archive for linux
NagyZoltanPeter Sep 17, 2024
8e08aa2
Add back -fPIC
NagyZoltanPeter Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions cpp/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ INCS = -I$(NEGENTROPY_ROOT) -I/opt/homebrew/include/ -I$(NEGENTROPY_ROOT)/vendor
ifeq ($(OS),Windows_NT)
TARGET = libnegentropy.dll
else
TARGET = libnegentropy.so
TARGET = libnegentropy.a
endif

.PHONY: all clean install-deps precompiled-header shared-lib
.PHONY: all clean install-deps precompiled-header build-lib

all: precompiled-header shared-lib
all: precompiled-header build-lib

#TODO: Need to add compilation flags based on OS
install-deps:
Expand All @@ -22,8 +22,13 @@ install-deps:
precompiled-header:
g++ -O0 --std=c++20 -Wall -fexceptions -g $(NEGENTROPY_ROOT)negentropy.h $(INCS)

shared-lib:
build-lib:
ifeq ($(OS),Windows_NT)
g++ -O0 -g -std=c++20 $(INCS) -shared -fPIC -o $(TARGET) $(NEGENTROPY_ROOT)negentropy_wrapper.cpp -lcrypto -lssl -L/opt/homebrew/lib/
else
g++ -O0 -g -std=c++20 $(INCS) -fPIC -c negentropy_wrapper.cpp
ar rcs $(TARGET) negentropy_wrapper.o
endif

clean:
rm -f $(TARGET) negentropy.h.gch libnegentropy.so
rm -f $(TARGET) negentropy.h.gch *.o
Comment thread
chaitanyaprem marked this conversation as resolved.