Skip to content

Fix multiple author displaying #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2020
Merged

Fix multiple author displaying #574

merged 2 commits into from
Aug 20, 2020

Conversation

@yang-er
Copy link
Contributor

@yang-er yang-er commented Aug 17, 2020

Previously, the author is displayed as by: author1author2. This fix make it by: author1 author2.

@loic-sharma
Copy link
Owner

loic-sharma commented Aug 19, 2020 •
edited
Loading

Thanks for the contribution, and nice catch! It looks like you'll need to update this test to return an array of strings:

BaGet/src/BaGet.UI/src/SearchResults.test.tsx

Line 38 in 7c514bf

authors: 'BaGet.Authors',

@loic-sharma loic-sharma merged commit a8bdf18 into loic-sharma:master Aug 20, 2020
@loic-sharma
Copy link
Owner

loic-sharma commented Aug 20, 2020

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yang-er @loic-sharma