Skip to content

chore: drop node 8 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2020
Merged

chore: drop node 8 #230

merged 1 commit into from
May 10, 2020

Conversation

jannyHou
Copy link
Contributor

@jannyHou jannyHou commented May 7, 2020

Node 8 has reached end of life. This PR drops support for it.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@jannyHou jannyHou requested review from dhmlau and emonddr as code owners May 7, 2020 19:35
@jannyHou jannyHou mentioned this pull request May 7, 2020
Merged
dhmlau
dhmlau approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please publish a semver-major version when publishing a new release. Thanks.

@jannyHou jannyHou merged commit 980b7e5 into master May 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the drop-node-8 branch May 10, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau dhmlau approved these changes

@agnes512 agnes512 agnes512 approved these changes

@emonddr emonddr Awaiting requested review from emonddr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jannyHou @dhmlau @agnes512