fix: upgrade libraries to fix CVE issues #240
Conversation
Fixes loopbackio#239 Signed-off-by: uma mahesh <[email protected]>
There was a problem hiding this comment.
@mahesh-uma, thanks for the PR. I've ran the tests locally with your changes. LGTM. Just have one minor comment about the change in .eslintrc.
Side note: we'd need to get the GitHub Actions running for CI.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "extends": "loopback", | |||
| "rules": { | |||
| "max-len": ["error", 125, 4, { | |||
| "max-len": ["error", 140, 4, { | |||
There was a problem hiding this comment.
any special reason to increase the length?
There was a problem hiding this comment.
when I run npm test, giving error saying needed 140. so i changed it.
(how to run github actions running for CI, Did i miss some thing )
There was a problem hiding this comment.
Sorry about the confusion. The GitHub Actions comment is for future reference. :)
Currently I'm verifying locally, but ideally we need to get GitHub Actions working for CI. But that's out of scope for this PR.
|
@mahesh-uma, thanks for the contribution. Your PR has landed! 🎉 |
Fixes #239
Resolve CVE issues
Signed-off-by: uma mahesh [email protected]