fix: deal with version >= 0.26.0

[looztra]

• Fixes Broken: not in gzip format  #4

• Fixes Implement ability to install using "latest" #5

• refactor: use new scripts

• fix: update for v0.26.x

• chore: update CI + use pre-commit

[github-actions]

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

No errors or shellcheck is disabled

shfmt erros

--- lib/utils.bash.orig
+++ lib/utils.bash
@@ -1,188 +1,188 @@
 #!/usr/bin/env bash
 
 set -euo pipefail
 
 GH_REPO="https://github.com/extrawurst/gitui"
 TOOL_NAME="gitui"
 TOOL_TEST="gitui --version"
 
 fail() {
   echo -e "asdf-$TOOL_NAME: $*"
   exit 1
 }
 
 curl_opts=(-fsSL)
 
 if [ -n "${GITHUB_API_TOKEN:-}" ]; then
   curl_opts=("${curl_opts[@]}" -H "Authorization: token $GITHUB_API_TOKEN")
 fi
 
 sort_versions() {
   sed 'h; s/[+-]/./g; s/.p\([[:digit:]]\)/.z\1/; s/$/.z/; G; s/\n/ /' |
     LC_ALL=C sort -t. -k 1,1 -k 2,2n -k 3,3n -k 4,4n -k 5,5n | awk '{print $2}'
 }
 
 list_github_tags() {
   git ls-remote --tags --refs "$GH_REPO" |
     grep -o 'refs/tags/.*' | cut -d/ -f3- |
     sed 's/^v//' # NOTE: You might want to adapt this sed to remove non-version strings from tags
 }
 
 list_all_versions() {
   list_github_tags
 }
 
 get_tool_cmd() {
   local tool_cmd
   tool_cmd="$(echo "$TOOL_TEST" | cut -d' ' -f1)"
   echo "${tool_cmd}"
 }
 
 download_release() {
   local version filename url
   version="$1"
   filename="$2"
 
   local platform_and_arch
   platform_and_arch="$(get_platform_and_arch "${version}")"
   local ext
   ext="$(get_ext)"
   # https://github.com/tj-actions/auto-doc/releases/download/v2.7.1/auto-doc_2.7.1_Linux_x86_64.tar.gz
   url="$GH_REPO/releases/download/v${version}/$(get_tool_cmd)-${platform_and_arch}${ext}"
 
   echo "* Downloading $TOOL_NAME release $version..."
   curl "${curl_opts[@]}" -o "$filename" -C - "$url" || fail "Could not download $url"
 }
 
 install_version() {
   local install_type="$1"
   local version="$2"
   local install_path="${3%/bin}/bin"
 
   if [ "$install_type" != "version" ]; then
     fail "asdf-$TOOL_NAME supports release installs only"
   fi
 
   (
     mkdir -p "$install_path"
     cp -r "$ASDF_DOWNLOAD_PATH"/* "$install_path"
 
     local tool_cmd
     tool_cmd="$(get_tool_cmd)"
     test -x "$install_path/$tool_cmd" || fail "Expected $install_path/$tool_cmd to be executable."
 
     echo "$TOOL_NAME $version installation was successful!"
     echo "* Install locally or globally with:"
     echo "asdf local $TOOL_NAME $version"
     echo "asdf global $TOOL_NAME $version"
   ) || (
     rm -rf "$install_path"
     fail "An error occurred while installing $TOOL_NAME $version."
   )
 }
 
 # from https://stackoverflow.com/questions/4023830/how-to-compare-two-strings-in-dot-separated-version-format-in-bash
 function vercomp() {
   if [[ "$1" == "$2" ]]; then
     return 0
   fi
   local IFS=.
   # shellcheck disable=SC2206
   local i ver1=($1) ver2=($2)
   # fill empty fields in ver1 with zeros
   for ((i = ${#ver1[@]}; i < ${#ver2[@]}; i++)); do
     ver1[i]=0
   done
   for ((i = 0; i < ${#ver1[@]}; i++)); do
     if [[ -z ${ver2[i]} ]]; then
       # fill empty fields in ver2 with zeros
       ver2[i]=0
     fi
     if ((10#${ver1[i]} > 10#${ver2[i]})); then
       return 1
     fi
     if ((10#${ver1[i]} < 10#${ver2[i]})); then
       return 2
     fi
   done
   return 0
 }
 
 function get_platform_and_arch() {
   local _v=${1?}
 
   local arch
   arch="$(get_arch)"
   local platform
   platform="$(get_platform)"
 
   if [[ "${arch}" == "x86_64" ]]; then
     vercomp "${_v}" "0.26.0"
     case $? in
-      2) arch="musl";;
+    2) arch="musl" ;;
     esac
   fi
 
   local platform_and_arch
   if [[ "${platform}" == "mac" ]] || [[ "${platform}" == "win" ]]; then
     platform_and_arch="${platform}"
   else
     platform_and_arch="${platform}"-"${arch}"
   fi
   echo "${platform_and_arch}"
 }
 
 get_arch() {
   arch=$(uname -m | tr '[:upper:]' '[:lower:]')
   case ${arch} in
   arm64)
     arch='arm64'
     ;;
   arm7)
     arch='armv7'
     ;;
   x86_64)
     arch='x86_64'
     ;;
   aarch64)
     arch='aarch64'
     ;;
   i386)
     arch='i386'
     ;;
   esac
 
   echo "${arch}"
 }
 
 get_platform() {
   plat=$(uname | tr '[:upper:]' '[:lower:]')
   case ${plat} in
   darwin)
     plat='mac'
     ;;
   linux)
     plat='linux'
     ;;
   windows)
     plat='win'
     ;;
   esac
 
   echo "${plat}"
 }
 
 get_ext() {
   plat=$(uname | tr '[:upper:]' '[:lower:]')
   case ${plat} in
   windows)
     ext='.zip'
     ;;
   *)
     ext='.tar.gz'
     ;;
   esac
 
   echo "${ext}"
 }
 

[github-actions]

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

No errors or shellcheck is disabled

shfmt erros

--- bin/latest-stable.orig
+++ bin/latest-stable
@@ -1,30 +1,30 @@
 #!/usr/bin/env bash
 
 set -euo pipefail
 
 current_script_path=${BASH_SOURCE[0]}
 plugin_dir=$(dirname "$(dirname "$current_script_path")")
 
 # shellcheck source=./lib/utils.bash
 . "${plugin_dir}/lib/utils.bash"
 
 curl_opts=(-sI)
 
 if [ -n "${GITHUB_API_TOKEN:-}" ]; then
-	curl_opts=("${curl_opts[@]}" -H "Authorization: token $GITHUB_API_TOKEN")
+  curl_opts=("${curl_opts[@]}" -H "Authorization: token $GITHUB_API_TOKEN")
 fi
 
 # curl of REPO/releases/latest is expected to be a 302 to another URL
 # when no releases redirect_url="REPO/releases"
 # when there are releases redirect_url="REPO/releases/tag/v<VERSION>"
 redirect_url=$(curl "${curl_opts[@]}" "$GH_REPO/releases/latest" | sed -n -e "s|^location: *||p" | sed -n -e "s|\r||p")
 version=
 printf "redirect url: %s\n" "$redirect_url" >&2
 if [[ "$redirect_url" == "$GH_REPO/releases" ]]; then
-	version="$(list_all_versions | sort_versions | tail -n1 | xargs echo)"
+  version="$(list_all_versions | sort_versions | tail -n1 | xargs echo)"
 else
-	version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\{0,1\}||')"
+  version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\{0,1\}||')"
 fi
 
 printf "%s\n" "$version"
 
--- lib/utils.bash.orig
+++ lib/utils.bash
@@ -1,188 +1,188 @@
 #!/usr/bin/env bash
 
 set -euo pipefail
 
 GH_REPO="https://github.com/extrawurst/gitui"
 TOOL_NAME="gitui"
 TOOL_TEST="gitui --version"
 
 fail() {
-	echo -e "asdf-$TOOL_NAME: $*"
-	exit 1
+  echo -e "asdf-$TOOL_NAME: $*"
+  exit 1
 }
 
 curl_opts=(-fsSL)
 
 if [ -n "${GITHUB_API_TOKEN:-}" ]; then
-	curl_opts=("${curl_opts[@]}" -H "Authorization: token $GITHUB_API_TOKEN")
+  curl_opts=("${curl_opts[@]}" -H "Authorization: token $GITHUB_API_TOKEN")
 fi
 
 sort_versions() {
-	sed 'h; s/[+-]/./g; s/.p\([[:digit:]]\)/.z\1/; s/$/.z/; G; s/\n/ /' |
-		LC_ALL=C sort -t. -k 1,1 -k 2,2n -k 3,3n -k 4,4n -k 5,5n | awk '{print $2}'
+  sed 'h; s/[+-]/./g; s/.p\([[:digit:]]\)/.z\1/; s/$/.z/; G; s/\n/ /' |
+    LC_ALL=C sort -t. -k 1,1 -k 2,2n -k 3,3n -k 4,4n -k 5,5n | awk '{print $2}'
 }
 
 list_github_tags() {
-	git ls-remote --tags --refs "$GH_REPO" |
-		grep -o 'refs/tags/.*' | cut -d/ -f3- |
-		sed 's/^v//' # NOTE: You might want to adapt this sed to remove non-version strings from tags
+  git ls-remote --tags --refs "$GH_REPO" |
+    grep -o 'refs/tags/.*' | cut -d/ -f3- |
+    sed 's/^v//' # NOTE: You might want to adapt this sed to remove non-version strings from tags
 }
 
 list_all_versions() {
-	list_github_tags
+  list_github_tags
 }
 
 get_tool_cmd() {
-	local tool_cmd
-	tool_cmd="$(echo "$TOOL_TEST" | cut -d' ' -f1)"
-	echo "${tool_cmd}"
+  local tool_cmd
+  tool_cmd="$(echo "$TOOL_TEST" | cut -d' ' -f1)"
+  echo "${tool_cmd}"
 }
 
 download_release() {
-	local version filename url
-	version="$1"
-	filename="$2"
+  local version filename url
+  version="$1"
+  filename="$2"
 
-	local platform_and_arch
-	platform_and_arch="$(get_platform_and_arch "${version}")"
-	local ext
-	ext="$(get_ext)"
-	# https://github.com/tj-actions/auto-doc/releases/download/v2.7.1/auto-doc_2.7.1_Linux_x86_64.tar.gz
-	url="$GH_REPO/releases/download/v${version}/$(get_tool_cmd)-${platform_and_arch}${ext}"
+  local platform_and_arch
+  platform_and_arch="$(get_platform_and_arch "${version}")"
+  local ext
+  ext="$(get_ext)"
+  # https://github.com/tj-actions/auto-doc/releases/download/v2.7.1/auto-doc_2.7.1_Linux_x86_64.tar.gz
+  url="$GH_REPO/releases/download/v${version}/$(get_tool_cmd)-${platform_and_arch}${ext}"
 
-	echo "* Downloading $TOOL_NAME release $version..."
-	curl "${curl_opts[@]}" -o "$filename" -C - "$url" || fail "Could not download $url"
+  echo "* Downloading $TOOL_NAME release $version..."
+  curl "${curl_opts[@]}" -o "$filename" -C - "$url" || fail "Could not download $url"
 }
 
 install_version() {
-	local install_type="$1"
-	local version="$2"
-	local install_path="${3%/bin}/bin"
+  local install_type="$1"
+  local version="$2"
+  local install_path="${3%/bin}/bin"
 
-	if [ "$install_type" != "version" ]; then
-		fail "asdf-$TOOL_NAME supports release installs only"
-	fi
+  if [ "$install_type" != "version" ]; then
+    fail "asdf-$TOOL_NAME supports release installs only"
+  fi
 
-	(
-		mkdir -p "$install_path"
-		cp -r "$ASDF_DOWNLOAD_PATH"/* "$install_path"
+  (
+    mkdir -p "$install_path"
+    cp -r "$ASDF_DOWNLOAD_PATH"/* "$install_path"
 
-		local tool_cmd
-		tool_cmd="$(get_tool_cmd)"
-		test -x "$install_path/$tool_cmd" || fail "Expected $install_path/$tool_cmd to be executable."
+    local tool_cmd
+    tool_cmd="$(get_tool_cmd)"
+    test -x "$install_path/$tool_cmd" || fail "Expected $install_path/$tool_cmd to be executable."
 
-		echo "$TOOL_NAME $version installation was successful!"
-		echo "* Install locally or globally with:"
-		echo "asdf local $TOOL_NAME $version"
-		echo "asdf global $TOOL_NAME $version"
-	) || (
-		rm -rf "$install_path"
-		fail "An error occurred while installing $TOOL_NAME $version."
-	)
+    echo "$TOOL_NAME $version installation was successful!"
+    echo "* Install locally or globally with:"
+    echo "asdf local $TOOL_NAME $version"
+    echo "asdf global $TOOL_NAME $version"
+  ) || (
+    rm -rf "$install_path"
+    fail "An error occurred while installing $TOOL_NAME $version."
+  )
 }
 
 # from https://stackoverflow.com/questions/4023830/how-to-compare-two-strings-in-dot-separated-version-format-in-bash
 function vercomp() {
-	if [[ "$1" == "$2" ]]; then
-		return 0
-	fi
-	local IFS=.
-	# shellcheck disable=SC2206
-	local i ver1=($1) ver2=($2)
-	# fill empty fields in ver1 with zeros
-	for ((i = ${#ver1[@]}; i < ${#ver2[@]}; i++)); do
-		ver1[i]=0
-	done
-	for ((i = 0; i < ${#ver1[@]}; i++)); do
-		if [[ -z ${ver2[i]} ]]; then
-			# fill empty fields in ver2 with zeros
-			ver2[i]=0
-		fi
-		if ((10#${ver1[i]} > 10#${ver2[i]})); then
-			return 1
-		fi
-		if ((10#${ver1[i]} < 10#${ver2[i]})); then
-			return 2
-		fi
-	done
-	return 0
+  if [[ "$1" == "$2" ]]; then
+    return 0
+  fi
+  local IFS=.
+  # shellcheck disable=SC2206
+  local i ver1=($1) ver2=($2)
+  # fill empty fields in ver1 with zeros
+  for ((i = ${#ver1[@]}; i < ${#ver2[@]}; i++)); do
+    ver1[i]=0
+  done
+  for ((i = 0; i < ${#ver1[@]}; i++)); do
+    if [[ -z ${ver2[i]} ]]; then
+      # fill empty fields in ver2 with zeros
+      ver2[i]=0
+    fi
+    if ((10#${ver1[i]} > 10#${ver2[i]})); then
+      return 1
+    fi
+    if ((10#${ver1[i]} < 10#${ver2[i]})); then
+      return 2
+    fi
+  done
+  return 0
 }
 
 function get_platform_and_arch() {
-	local _v=${1?}
+  local _v=${1?}
 
-	local arch
-	arch="$(get_arch)"
-	local platform
-	platform="$(get_platform)"
+  local arch
+  arch="$(get_arch)"
+  local platform
+  platform="$(get_platform)"
 
-	if [[ "${arch}" == "x86_64" ]]; then
-		vercomp "${_v}" "0.26.0"
-		case $? in
-		2) arch="musl" ;;
-		esac
-	fi
+  if [[ "${arch}" == "x86_64" ]]; then
+    vercomp "${_v}" "0.26.0"
+    case $? in
+    2) arch="musl" ;;
+    esac
+  fi
 
-	local platform_and_arch
-	if [[ "${platform}" == "mac" ]] || [[ "${platform}" == "win" ]]; then
-		platform_and_arch="${platform}"
-	else
-		platform_and_arch="${platform}"-"${arch}"
-	fi
-	echo "${platform_and_arch}"
+  local platform_and_arch
+  if [[ "${platform}" == "mac" ]] || [[ "${platform}" == "win" ]]; then
+    platform_and_arch="${platform}"
+  else
+    platform_and_arch="${platform}"-"${arch}"
+  fi
+  echo "${platform_and_arch}"
 }
 
 get_arch() {
-	arch=$(uname -m | tr '[:upper:]' '[:lower:]')
-	case ${arch} in
-	arm64)
-		arch='arm64'
-		;;
-	arm7)
-		arch='armv7'
-		;;
-	x86_64)
-		arch='x86_64'
-		;;
-	aarch64)
-		arch='aarch64'
-		;;
-	i386)
-		arch='i386'
-		;;
-	esac
+  arch=$(uname -m | tr '[:upper:]' '[:lower:]')
+  case ${arch} in
+  arm64)
+    arch='arm64'
+    ;;
+  arm7)
+    arch='armv7'
+    ;;
+  x86_64)
+    arch='x86_64'
+    ;;
+  aarch64)
+    arch='aarch64'
+    ;;
+  i386)
+    arch='i386'
+    ;;
+  esac
 
-	echo "${arch}"
+  echo "${arch}"
 }
 
 get_platform() {
-	plat=$(uname | tr '[:upper:]' '[:lower:]')
-	case ${plat} in
-	darwin)
-		plat='mac'
-		;;
-	linux)
-		plat='linux'
-		;;
-	windows)
-		plat='win'
-		;;
-	esac
+  plat=$(uname | tr '[:upper:]' '[:lower:]')
+  case ${plat} in
+  darwin)
+    plat='mac'
+    ;;
+  linux)
+    plat='linux'
+    ;;
+  windows)
+    plat='win'
+    ;;
+  esac
 
-	echo "${plat}"
+  echo "${plat}"
 }
 
 get_ext() {
-	plat=$(uname | tr '[:upper:]' '[:lower:]')
-	case ${plat} in
-	windows)
-		ext='.zip'
-		;;
-	*)
-		ext='.tar.gz'
-		;;
-	esac
+  plat=$(uname | tr '[:upper:]' '[:lower:]')
+  case ${plat} in
+  windows)
+    ext='.zip'
+    ;;
+  *)
+    ext='.tar.gz'
+    ;;
+  esac
 
-	echo "${ext}"
+  echo "${ext}"
 }