-
-
Notifications
You must be signed in to change notification settings - Fork 50
simple pkgdown check #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple pkgdown check #393
Conversation
@gravesti thanks for your work. This works now in principle. Only practical problem are the heavly dependencies, in particular in a CI setting. So, it may work best if you use {pkgdown} already locally and have all the system dependencies. {pkgdown} has many dependencies and system dependencies that are required to make loading the package not error, but not required for our functionality... Probably, these checks would just be skipped in CI then. Coming from the problem use case: {pkgdown} builds are only triggered on default branches, so even if a PR succeeds, we don't know if the pkgdown build will succeed. Hence, instead (or as a complement) of a pre-commit hook, the GitHub Action for pkgdown could also build the page and not deploy it. Should I file an issue in r-lib/actions for this? |
I thought about it again and I think we should merge the hook, but use |
af37498
to
3f1026a
Compare
for more information, see https://pre-commit.ci
This is useful for people who use the template and don't have pkgdown activated.
bd88725
to
0ce2c91
Compare
0ce2c91
to
96b1f46
Compare
I note that in the mean time pkgdown implemented a |
Thanks @gravesti. I spend at least 5h working on this PR (and some related issues that came up due to it) over the last 3 days. -.- I see that you mentioned that you opened an issue in {pkgdown}, can you please link it next time? Would have saved me a lot of time I think. |
First attempt to implement quick checks for {pkgdown}. Fixes #378