feat(ssl options): support SNI hostname

[bf4]

The HTTPX gem supports this OpenSSL::SSL::SSLSocket#hostname= option

Description

The HTTPX gem supports the ssl option hostname= but, when using the Faraday adapter, it raises an error

NameError: no member 'hostname' in struct (NameError)

        target[key] = if value.is_a?(Hash) && (target[key].is_a?(Hash) || target[key].is_a?(Options))
              ^^^^^^^

This option is defined as OpenSSL::SSL::SSLSocket#hostname and looks like it has been around a long time ruby/openssl#81

I've found it helpful when using a SOCKS5 proxy and I want to set the hostname for use in verifying the certificate. Without this change, I need to set OpenSSL::SSL::VERIFY_NONE

Todos

Not sure if tests or documentation are needed

Additional Notes

Happy to make any changes needed.

[iMacTia]

Sorry @bf4 I somehow missed this until now, taking a look now 👀

[iMacTia]

OK so a couple minor fixes are needed to make this ready to merge. I've found this old PR doing something similar that you can use as a guideline.

1. Update the docs/customization/ssl-options.md file with the new option;
2. Fix the failing utils_spec.rb

[bf4]

Thanks @iMacTia for the helpful reference PR. Pushed a new commit

[bf4]

Merge branch 'main' into patch-1

Thanks 😊 I should have done that 🤦

[olleolleolle]

Hm, is that a very old Ruby docs link?

[bf4]

Agreed.. was just being consistent within the file without expanding scope to change more.

The two files also use different docs paths.

I'm not surprised you noticed as well given how small the pr is

[iMacTia]

Ahaha yeah the ciphers comment also points to 2.5.1! Definitely needs an update but agree we can do that in a follow-up PR 👍